From: "Martin Storsjö" <martin@martin.st>
To: binutils@sourceware.org
Cc: Marcus Shawcroft <marcus.shawcroft@arm.com>
Subject: Re: [PATCH] aarch64: Fix the documentation on :pg_hi21:
Date: Thu, 05 Jun 2014 20:37:00 -0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1406052336030.14339@cone.martin.st> (raw)
In-Reply-To: <alpine.DEB.2.02.1406032318130.14339@cone.martin.st>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2758 bytes --]
Hi Marcus and Yufeng,
On Tue, 3 Jun 2014, Martin Storsjö wrote:
> On Mon, 2 Jun 2014, Martin Storsjo wrote:
>
>> The syntax described, including a leading '#', was not supported
>> in practice. (For :lo12: it is optional.)
>> ---
>> Added a ChangeLog entry.
>> ---
>> gas/ChangeLog | 4 ++++
>> gas/doc/c-aarch64.texi | 10 +++++-----
>> 2 files changed, 9 insertions(+), 5 deletions(-)
>>
>> diff --git a/gas/ChangeLog b/gas/ChangeLog
>> index 98186d3..911511e 100644
>> --- a/gas/ChangeLog
>> +++ b/gas/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2014-06-02 Martin Storsjo <martin@martin.st>
>> +
>> + * doc/c-aarch64.texi: Fix the documentation on :pg_hi21:.
>> +
>> 2014-05-22 Alan Modra <amodra@gmail.com>
>>
>> * listing.c (listing_warning, listing_error): Add space after colon.
>> diff --git a/gas/doc/c-aarch64.texi b/gas/doc/c-aarch64.texi
>> index cce4f61..3d84123 100644
>> --- a/gas/doc/c-aarch64.texi
>> +++ b/gas/doc/c-aarch64.texi
>> @@ -186,24 +186,24 @@ For example to load the 48-bit absolute address of
>> @var{foo} into x0:
>> @cindex ADRP, ADD, LDR/STR group relocations, AArch64
>> Relocations for @samp{ADRP}, and @samp{ADD}, @samp{LDR} or @samp{STR}
>> instructions can be generated by prefixing the label with
>> -@samp{#:pg_hi21:} and @samp{#:lo12:} respectively.
>> +@samp{:pg_hi21:} and @samp{:lo12:} respectively.
>>
>> For example to use 33-bit (+/-4GB) pc-relative addressing to
>> load the address of @var{foo} into x0:
>>
>> @smallexample
>> - adrp x0, #:pg_hi21:foo
>> + adrp x0, :pg_hi21:foo
>> add x0, x0, #:lo12:foo
>> @end smallexample
>>
>> Or to load the value of @var{foo} into x0:
>>
>> @smallexample
>> - adrp x0, #:pg_hi21:foo
>> + adrp x0, :pg_hi21:foo
>> ldr x0, [x0, #:lo12:foo]
>> @end smallexample
>>
>> -Note that @samp{#:pg_hi21:} is optional.
>> +Note that @samp{:pg_hi21:} is optional.
>>
>> @smallexample
>> adrp x0, foo
>> @@ -212,7 +212,7 @@ Note that @samp{#:pg_hi21:} is optional.
>> is equivalent to
>>
>> @smallexample
>> - adrp x0, #:pg_hi21:foo
>> + adrp x0, :pg_hi21:foo
>> @end smallexample
>>
>> @node AArch64 Floating Point
>> --
>> 1.8.5.2 (Apple Git-48)
>
> Can someone apply and push this one? It was approved by Marcus yesterday, but
> since I can't push it myself, the ChangeLog has gotten another conflicting
> entry now - so whoever applies it will have to fix it up. (I won't try to
> send a new resolved patch because someone else will probably touch the
> ChangeLog inbetween again, before someone gets to pushing it.)
Ping - can either of you (or someone else with commit access) apply and
push this approved patch? I obviously can't do it myself since I don't
have push access.
// Martin
next prev parent reply other threads:[~2014-06-05 20:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 12:00 Martin Storsjo
2014-05-29 12:19 ` Yufeng Zhang
2014-05-29 13:04 ` [PATCH] aarch64: Support an optional '#' in the second adrp operand Martin Storsjo
2014-05-29 16:27 ` [PATCH] aarch64: Fix the documentation on :pg_hi21: Yufeng Zhang
2014-05-29 17:57 ` Martin Storsjö
2014-05-29 17:58 ` Martin Storsjo
2014-06-02 13:45 ` Marcus Shawcroft
2014-06-02 19:31 ` Martin Storsjo
2014-06-03 20:20 ` Martin Storsjö
2014-06-05 20:37 ` Martin Storsjö [this message]
2014-06-06 6:30 ` Marcus Shawcroft
2014-06-06 10:10 ` Richard Earnshaw
2014-06-06 10:18 ` Martin Storsjö
2014-06-06 10:22 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1406052336030.14339@cone.martin.st \
--to=martin@martin.st \
--cc=binutils@sourceware.org \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).