From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18674 invoked by alias); 19 Dec 2014 16:15:21 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 18438 invoked by uid 89); 19 Dec 2014 16:15:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Dec 2014 16:15:14 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1Y20Cs-0004c4-Ej from joseph_myers@mentor.com ; Fri, 19 Dec 2014 08:15:10 -0800 Received: from digraph.polyomino.org.uk (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.181.6; Fri, 19 Dec 2014 16:15:08 +0000 Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.82) (envelope-from ) id 1Y20Ct-0001qn-De; Fri, 19 Dec 2014 16:15:11 +0000 Date: Fri, 19 Dec 2014 16:15:00 -0000 From: Joseph Myers To: James Bowman CC: "binutils@sourceware.org" Subject: Re: [PATCH, FT32] initial support In-Reply-To: Message-ID: References: User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-SW-Source: 2014-12/txt/msg00215.txt.bz2 config.sub should never be patched locally in binutils-gdb; you need to get the change into config.git then propose an import of the updated config.sub into binutils-gdb. Your toplevel configure.ac and configure changes don't match (that is, the configure change does not look like a correct regeneration after changing configure.ac). Furthermore, I refactored the disabling of subdirectories for particular targets in toplevel configure.ac some years ago; you're modifying the section for disabling libgcj, but the disabling of other subdirectories you also have in the patch needs to go elsewhere in configure.ac (whether in the target-libstdc++-v3 section, or the miscellaneous section). The GDB (and sim) port needs submitting to gdb-patches. Do you have a reason for not using an official e_machine value obtained from registry@sco.com? I'd expect a binutils port to include at least some readelf changes. -- Joseph S. Myers joseph@codesourcery.com