From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id 5F7393858429 for ; Thu, 10 Mar 2022 10:12:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5F7393858429 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 042E592009C; Thu, 10 Mar 2022 11:11:59 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id E959792009B; Thu, 10 Mar 2022 10:11:59 +0000 (GMT) Date: Thu, 10 Mar 2022 10:11:59 +0000 (GMT) From: "Maciej W. Rozycki" To: Sagar Patel cc: binutils@sourceware.org Subject: Re: [PATCH] MIPS/opcodes: Fix alias annotation for negate instructions In-Reply-To: Message-ID: References: <20220307151833.22389-1-sagarmp@cs.unc.edu> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1162.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_INFOUSMEBIZ, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 10:12:07 -0000 On Tue, 8 Mar 2022, Sagar Patel wrote: > > This might be overly pedantic, but with any test case I suggest putting > > the absolute minimum there so as not to make someone in the future wonder > > what the specific requirement was for one option or another (possibly I > > shouldn't have used `.set noat' and $1 either, but let's leave it as it > > is). > > I agree. I can remove the use of `.set noat' in the two new test > sources. Should I do that? Please do whatever you prefer and I will accept your choice. This is a minor difference and I surely cannot impose requirements on you that I do not stick to myself. > > It looks perfect otherwise and once your paperwork has been sorted I will > > push either your change as posted with amendments made for the two pieces > > above or any v2 if you prefer to make one yourself. > > Just to keep you in the loop, I sent in the request for the paperwork. > I'll let you know if I don't hear back soon. Ack, thanks. Maciej