public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>
Cc: binutils@sourceware.org, arikalo@gmail.com,
	 Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH v4] Add support for nanoMIPS architecture
Date: Fri, 25 Nov 2022 11:22:04 +0000 (GMT)	[thread overview]
Message-ID: <alpine.DEB.2.21.2211242215400.41742@angie.orcam.me.uk> (raw)
In-Reply-To: <20221124154531.903548-1-aleksandar.rikalo@syrmia.com>

On Thu, 24 Nov 2022, Aleksandar Rikalo wrote:

> diff --git a/binutils/readelf.c b/binutils/readelf.c
> index 365c1ede0a1..5e0bda4d412 100644
> --- a/binutils/readelf.c
> +++ b/binutils/readelf.c
> @@ -1097,6 +1098,7 @@ guess_is_rela (unsigned int e_machine)
>      case EM_MSP430:
>      case EM_MSP430_OLD:
>      case EM_MT:
> +    case EM_IMG1:
>      case EM_NDS32:
>      case EM_NIOS32:
>      case EM_OR1K:

 Actually using EM_NANOMIPS throughout just as in v3 would make more sense 
than EM_IMG1.  The sole reason for the existence of EM_IMG1 was to have a 
placeholder before the name of nanoMIPS project could have been disclosed 
to the public.  I remember this being discussed, though I can't find a 
reference now (perhaps it was internal).

  Maciej

  reply	other threads:[~2022-11-25 11:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-24 15:45 Aleksandar Rikalo
2022-11-25 11:22 ` Maciej W. Rozycki [this message]
2022-11-25 14:57   ` Aleksandar Rikalo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.2211242215400.41742@angie.orcam.me.uk \
    --to=macro@orcam.me.uk \
    --cc=aleksandar.rikalo@syrmia.com \
    --cc=arikalo@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).