From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id 8EB333858D1E for ; Tue, 25 Apr 2023 10:02:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8EB333858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 08EED92009C; Tue, 25 Apr 2023 12:02:42 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id F267992009B; Tue, 25 Apr 2023 11:02:42 +0100 (BST) Date: Tue, 25 Apr 2023 11:02:42 +0100 (BST) From: "Maciej W. Rozycki" To: YunQiang Su cc: binutils@sourceware.org, syq@debian.org, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32 In-Reply-To: <20230425065626.3587754-1-yunqiang.su@cipunited.com> Message-ID: References: <20230425065626.3587754-1-yunqiang.su@cipunited.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1169.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 25 Apr 2023, YunQiang Su wrote: > diff --git a/opcodes/micromips-opc.c b/opcodes/micromips-opc.c > index 94812a68c82..5a6460d9b8b 100644 > --- a/opcodes/micromips-opc.c > +++ b/opcodes/micromips-opc.c > @@ -148,6 +148,10 @@ decode_micromips_operand (const char *p) > case '~': SINT (12, 0); > case '@': SINT (10, 16); > case '^': HINT (5, 11); > + case '*': REG (2, 23, ACC); > + case '!': UINT (1, 10); > + case '$': UINT (1, 9); > + case '&': REG (2, 18, ACC); > > case '0': SINT (6, 16); > case '1': HINT (5, 16); > @@ -165,6 +169,7 @@ decode_micromips_operand (const char *p) > case 'G': REG (5, 16, COPRO); > case 'K': REG (5, 16, HW); > case 'H': UINT (3, 11); > + case 'O': UINT (3, 4); > case 'M': REG (3, 13, CCC); > case 'N': REG (3, 18, CCC); > case 'R': REG (5, 6, FP); When adding new operand formats you need to document them in include/opcode/mips.h. NB this is not a full review. Maciej