From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=ET3p=AQ=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id DFDDE3858C60
	for <binutils@sourceware.org>; Tue, 25 Apr 2023 10:45:00 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DFDDE3858C60
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 47F8892009D; Tue, 25 Apr 2023 12:45:00 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 43AF992009C;
	Tue, 25 Apr 2023 11:45:00 +0100 (BST)
Date: Tue, 25 Apr 2023 11:45:00 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@debian.org>
cc: YunQiang Su <yunqiang.su@cipunited.com>, binutils@sourceware.org, 
    xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32
In-Reply-To: <CAKcpw6Xc=iM3XMfwQt+DSo4TC2Qj=a2eF9KRmfvWU1rNxqkSTQ@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2304251137430.58739@angie.orcam.me.uk>
References: <20230425065626.3587754-1-yunqiang.su@cipunited.com> <alpine.DEB.2.21.2304251059540.58739@angie.orcam.me.uk> <CAKcpw6Xc=iM3XMfwQt+DSo4TC2Qj=a2eF9KRmfvWU1rNxqkSTQ@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1162.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Tue, 25 Apr 2023, YunQiang Su wrote:

> >  When adding new operand formats you need to document them in
> > include/opcode/mips.h.  NB this is not a full review.
> >
> Thank you. Are these lines OK for it?
> 
>    DSP ASE usage:
>    "*" 2-bit unsigned immediate in rt section for MFTR
>    "&" 2-bit unsigned immediate in rs section for MTTR
>    "!" 1-bit 'u' value in MFTR/MTTR
>    "$" 1-bit 'h' value in MFTR/MTTR
>    "O" 3-bit 'sel' value in MFTR/MTTR

 I suggest that you borrow the wording from the regular MIPS section, 
which describes the meaning of the opcode fields and not just the raw 
encoding.  Also you need to update character usage tables.

  Maciej