From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id C72223858D1E for ; Tue, 2 May 2023 19:33:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C72223858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 2517792009C; Tue, 2 May 2023 21:33:00 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 1EBD692009B; Tue, 2 May 2023 20:33:00 +0100 (BST) Date: Tue, 2 May 2023 20:33:00 +0100 (BST) From: "Maciej W. Rozycki" To: YunQiang Su cc: Alan Modra , binutils@sourceware.org, YunQiang Su , RichardSandifordrichard.sandiford@arm.com, Chenghua Xu Subject: Re: mips64-linux-gnuabi64 testsuite breakage In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3488.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 26 Apr 2023, YunQiang Su wrote: > > Since 32f1c80375e "MIPS: support mips*64 as CPU and gnuabi64 as ABI", > > I will fix the test suite. > The reason is that: the previous test suite assumes the default ABI is > n32 even the triple > with -gnuabi64. I can see extra 3346 regressions across various MIPS targets compared to a checkout from Jan. Including ones like (parts of log trimmed for clarity): ../as-new --defsym count=960 /scratch/vol1/binutils/binutils-mips-test/binutils-src/gas/testsuite/gas/mips/branch-swap-2.s gas/testsuite/gas/mips/branch-swap-2.s:1: Fatal error: `micromips' cannot be used with `mips32r6' FAIL: MIPS branch swapping (960) for `mips-img-elf' which indicates that the default architecture has changed for GAS for this target. I think this is due to your commit 9171de358f23 ("MIPS: default output r6 obj if the triple is r6"), which has this part among others: + # If Vendor is IMG, then MIPSr6 is used + case ${target} in + mips*64*-img-*) + mips_cpu=mips64r6 + ;; + mips*-img-*) + mips_cpu=mips32r6 + ;; + esac Not only this change is wrong (you can't just arbitrarily change a configuration that has been in the wild for ~8.5 years as it'll break things for people who rely on the established semantics), but it hasn't been properly verified either, as a change is supposed not to cause regressions in the testsuite. Please revert the part quoted and fix the regressions. Thank you. Maciej