From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 8BED93857353 for ; Sat, 6 May 2023 23:11:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BED93857353 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 3728892009C; Sun, 7 May 2023 01:11:15 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 3076A92009B; Sun, 7 May 2023 00:11:15 +0100 (BST) Date: Sun, 7 May 2023 00:11:15 +0100 (BST) From: "Maciej W. Rozycki" To: david@davidgf.es cc: binutils@sourceware.org Subject: Re: [PATCH 2/3] Add rotation instructions to allegrex CPU In-Reply-To: <20230328230249.274759-3-david@davidgf.es> Message-ID: References: <20230328230249.274759-1-david@davidgf.es> <20230328230249.274759-3-david@davidgf.es> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3494.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 29 Mar 2023, david@davidgf.es wrote: > From: David Guillen Fandos Again, at least a short introduction is needed here. > diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp > index f28ea7e695..9f17f20643 100644 > --- a/gas/testsuite/gas/mips/mips.exp > +++ b/gas/testsuite/gas/mips/mips.exp > @@ -536,7 +536,7 @@ mips_arch_create xlr 64 mips64 { oddspreg } \ > mips_arch_create r5900 64 mips3 { gpr_ilocks singlefloat nollsc } \ > { -march=r5900 -mtune=r5900 } { -mmips:5900 } \ > { mipsr5900el-*-* mips64r5900el-*-* } > -mips_arch_create allegrex 32 mips2 { singlefloat oddspreg } \ > +mips_arch_create allegrex 32 mips2 { singlefloat ror oddspreg } \ Please keep the flags in the same order as they're documented at the top of the file, i.e. put `ror' ahead of `singlefloat'. Otherwise this is OK. Maciej