From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2Wzy=A3=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id 4EFCA3858D28
	for <binutils@sourceware.org>; Sat,  6 May 2023 23:14:57 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EFCA3858D28
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id B056292009C; Sun,  7 May 2023 01:14:56 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id A17E892009B;
	Sun,  7 May 2023 00:14:56 +0100 (BST)
Date: Sun, 7 May 2023 00:14:56 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: David Guillen Fandos <david@davidgf.net>
cc: binutils@sourceware.org, xuchenghua@loongson.cn
Subject: Re: [PATCH 0/3] Add support for MIPS Allegrex
In-Reply-To: <CADQAGROrOxK_XH2ETveHMUmNrqCdKMW2=N4+O_T8dpTHEkRPZg@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2305062352510.54316@angie.orcam.me.uk>
References: <20230328230249.274759-1-david@davidgf.es> <CADQAGRNTMsd_qqAXyGTLUFe78gY0fYhCDSw3fyAqVxc9kAQ72w@mail.gmail.com> <alpine.DEB.2.21.2304252310470.58739@angie.orcam.me.uk> <CADQAGROrOxK_XH2ETveHMUmNrqCdKMW2=N4+O_T8dpTHEkRPZg@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3488.9 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Sat, 6 May 2023, David Guillen Fandos wrote:

> >  Thank you for pinging me directly, I'm not very up to date on mailing
> > list traffic right now.  I'll review your submission over this coming
> > weekend.
> 
> Awesome! Thank you very much! I'm looking forward to your review.
> I picked you since your name showed up in the MAINTAINERS file, but
> feel free to suggest any other person you think could be interested in
> the review.

 I ran out of steam over the last weekend, so apologies for this delay.

 Overall your code looks pretty good to me, I wish all submissions were so 
good.  I have spotted some minor issues however, please see my replies to 
individual patches for details, and resubmit the changes with the problems 
addressed.

 I have pushed your changes through regression testing across my usual 
MIPS targets and results were good except as noted in the replies.

 There is one ouststanding concern as to the copyright to your changes.  
There are two ways to move forward here, either by assigning the copyright 
to the Free Software Foundation, or by agreeing to the Developer's 
Certificate of Origin.  Please review section "Patches and Copyright" in 
binutils/MAINTAINERS and let me know what you have chosen.  You may have 
to update your submission accordingly.

 In any case please let me know if you have any questions or concerns or 
find anything what I wrote unclear.

 Thank you for your submission.

  Maciej