From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=a8Gc=A4=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id 094C53858D32
	for <binutils@sourceware.org>; Sun,  7 May 2023 17:46:03 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 094C53858D32
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 69D8192009C; Sun,  7 May 2023 19:46:02 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 5EDB092009B;
	Sun,  7 May 2023 18:46:02 +0100 (BST)
Date: Sun, 7 May 2023 18:46:02 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <wzssyqa@gmail.com>
cc: Alan Modra <amodra@gmail.com>, binutils@sourceware.org, 
    YunQiang Su <yunqiang.su@cipunited.com>, 
    RichardSandifordrichard.sandiford@arm.com, 
    Chenghua Xu <paul.hua.gm@gmail.com>
Subject: Re: mips64-linux-gnuabi64 testsuite breakage
In-Reply-To: <CAKcpw6XmQ7-PKJZyijoBy-G6shPZ9FNOADVsdX9B9YZcJ4xG8A@mail.gmail.com>
Message-ID: <alpine.DEB.2.21.2305071836490.54316@angie.orcam.me.uk>
References: <ZEiuLqBNxquOlw+e@squeak.grove.modra.org> <CAKcpw6VA5T3aiucCico+iXM21g0AP9iGSTDZdvXdced8RBss-Q@mail.gmail.com> <alpine.DEB.2.21.2305022016160.41756@angie.orcam.me.uk> <CAKcpw6XmQ7-PKJZyijoBy-G6shPZ9FNOADVsdX9B9YZcJ4xG8A@mail.gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1163.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Thu, 4 May 2023, YunQiang Su wrote:

> > +       # If Vendor is IMG, then MIPSr6 is used
> > +       case ${target} in
> > +         mips*64*-img-*)
> > +           mips_cpu=mips64r6
> > +           ;;
> > +         mips*-img-*)
> > +           mips_cpu=mips32r6
> > +           ;;
> > +       esac
> >
> > Not only this change is wrong (you can't just arbitrarily change a
> > configuration that has been in the wild for ~8.5 years as it'll break
> > things for people who rely on the established semantics), but it hasn't
> > been properly verified either, as a change is supposed not to cause
> > regressions in the testsuite.
> >
> >  Please revert the part quoted and fix the regressions.  Thank you.
> 
> Reverted.

 Thank you.

 FAOD if you think a triplet that implicitly defaults to R6 is useful, 
then feel free to submit a change for say `mips*-cipunited-*' to do so (or 
maybe `mips*-cip-*' if you want to keep it short and the company policy 
allows using such a short name), as this would be a configuration that had 
no previous mention/semantics in our tree and therefore I would have no 
concerns about it.

 Overall I'd suggest the `--with-arch=' approach previously discussed and 
already implemented for MIPS targets in GCC and also some other targets in 
binutils.  It is more generic, although it may complicate testing, so it 
may have to be deployed with care.

> And I am working on fix the tesutsuite for `-gnuabi64` and `mipsisaXXr6`.

 I look forward to your fixes.

  Maciej