From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: binutils@sourceware.org, syq@debian.org, xry111@xry111.site,
richard.sandiford@arm.com, jiaxun.yang@flygoat.com,
Alan Modra <amodra@gmail.com>
Subject: Re: [PATCH] MIPS: fix loongson3 llsc workaround
Date: Thu, 11 May 2023 01:00:32 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305110050000.54316@angie.orcam.me.uk> (raw)
In-Reply-To: <20230323105959.1449936-1-yunqiang.su@cipunited.com>
On Thu, 23 Mar 2023, YunQiang Su wrote:
> -mfix-looongson3-llsc may add sync instructions not needed on some
> asm code with lots of debug info.
I can see the change has been committed, but who has actually reviewed
it?
The change description doesn't say what the change actually does, so one
can't say whether it is correct or not. At least an example of incorrect
code produced ought to be shown and how the change affects it. As it
stands I have no idea what is going on here, and surely no one who looks
at it in a few year's time will.
Change descriptions cannot be retrofitted, so I think the original fix
ought to be reverted and, assuming it is indeed the correct one, reapplied
with a correct change description (after a proper review).
Maciej
next prev parent reply other threads:[~2023-05-11 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 10:59 YunQiang Su
2023-04-10 6:37 ` YunQiang Su
2023-05-11 0:00 ` Maciej W. Rozycki [this message]
2023-05-11 0:15 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305110050000.54316@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=jiaxun.yang@flygoat.com \
--cc=richard.sandiford@arm.com \
--cc=syq@debian.org \
--cc=xry111@xry111.site \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).