From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Richard Sandiford <richard.sandiford@arm.com>
Cc: YunQiang Su <wzssyqa@gmail.com>, Alan Modra <amodra@gmail.com>,
binutils@sourceware.org, YunQiang Su <yunqiang.su@cipunited.com>,
Chenghua Xu <paul.hua.gm@gmail.com>
Subject: Re: mips64-linux-gnuabi64 testsuite breakage
Date: Thu, 18 May 2023 16:58:51 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2305180215090.50034@angie.orcam.me.uk> (raw)
In-Reply-To: <mptild1rkh8.fsf@arm.com>
On Tue, 9 May 2023, Richard Sandiford wrote:
> > Not only this change is wrong (you can't just arbitrarily change a
> > configuration that has been in the wild for ~8.5 years as it'll break
> > things for people who rely on the established semantics),
>
> It wasn't supposed to be an arbitrary change, but instead was supposed
> to sync GAS's default to GCC's. The GCC img toolchain has been an r6
> toolchain since it was added in 2014. The fact that GAS instead defaults
> to mips1/mips3 seems like a bug, since mips1 isn't link-compatible with
> mips32r6 and mips3 isn't link-compatible with mips64r6.
Fair enough, but:
1. It should have been submitted as a distinct patch on its own, rather
than bundled with an unrelated change.
2. The rationale as you quote it should have been given in the change
description.
> > Please revert the part quoted and fix the regressions. Thank you.
>
> ...I think it does make sense to resurrect the patch in a testsuite-friendly
> form.
And following the patch submission requirements repeated above, right.
Maciej
prev parent reply other threads:[~2023-05-18 15:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 4:53 Alan Modra
2023-04-26 5:46 ` YunQiang Su
2023-05-02 19:33 ` Maciej W. Rozycki
2023-05-04 1:55 ` YunQiang Su
2023-05-07 17:46 ` Maciej W. Rozycki
2023-05-09 3:15 ` YunQiang Su
2023-05-09 8:13 ` Richard Sandiford
2023-05-18 15:58 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2305180215090.50034@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=paul.hua.gm@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=wzssyqa@gmail.com \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).