Re: [PATCH] gas: documents .gnu_attribute Tag_GNU_MIPS_ABI_MSA

["Maciej W. Rozycki" <macro@orcam.me.uk>]

On Fri, 19 May 2023, YunQiang Su wrote:

> > > It is added since 2016 by
> > >   Add support for .MIPS.abiflags and .gnu.attributes sections
> > >   b52717c0e104eb603e8189c3c0d3658ef5d903f5
> > > But never documented.
> >
> >  Hmm, I can see this has been committed, but who has actually approved
> > this change?
> >
> 
> Yes. I believe this change is an "obvious" change, as descripted in
> 
> Read-write Git access - GNU Project: https://gcc.gnu.org/gitwrite.html

 Under this rule you can push a commit right away as long as you post the 
change committed to our mailing list afterwards, or if you post beforehand 
mentioning that you intend to push unless you hear objections within some 
reasonable time, but you do need to state there that the change has been 
or will be committed under the "obviously correct" rule.

 Also your change is actually not obviously correct, because it has a
defect in formatting: an overlong line that exceeds 79 columns (staying 
within 74 is preferred where feasible).

 Finally for a non-native English speaker it's always good to have 
documentation changes reviewed as this is what our users will read, and 
the last thing we want is documentation that seems unprofessional.  In 
this case you have an inconsistency between the two cases: one uses the 
singular and the other one uses the plural form of the noun, which is bad 
style.  I find the style of the commit description so-so as well.  Being 
internal only it's less of a problem, albeit unfixable once pushed.

  Maciej