From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 863B43858D20 for ; Wed, 31 May 2023 11:09:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 863B43858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id CC3CA92009C; Wed, 31 May 2023 13:09:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id C60C992009B; Wed, 31 May 2023 12:09:13 +0100 (BST) Date: Wed, 31 May 2023 12:09:13 +0100 (BST) From: "Maciej W. Rozycki" To: YunQiang Su cc: Alan Modra , YunQiang Su , binutils@sourceware.org, xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com Subject: Re: [PATCH v2 0/5] Some MIPS changes and testsuite fixes In-Reply-To: Message-ID: References: <20230516025426.2334478-1-yunqiang.su@cipunited.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3488.8 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 31 May 2023, YunQiang Su wrote: > > I applied your patchset and ran my usual regression tests over some > > 165 different binutils targets. mipsisa32r2el-elf, mips-sgi-irix6, > > and mipstx39-elf show some new failures. This doesn't mean I > > disapprove the patch, in fact I like it! Please don't think you must > > post another version of the patchset to fix these problems. It might > > be better to solve them with an incremental patch, giving the mips > > maintainers a chance to review this patchset first. > > If there is no objection, I will commit this patchset and go on to solve > the problem Alan pointed out. Well, it does have to be reviewed, especially as there are changes beyond just testsuite fixes. Maciej