From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=nY5M=CD=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id C900A3856DC2
	for <binutils@sourceware.org>; Thu, 15 Jun 2023 03:50:07 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C900A3856DC2
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id D87D592009C; Thu, 15 Jun 2023 05:50:06 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id D292F92009B;
	Thu, 15 Jun 2023 04:50:06 +0100 (BST)
Date: Thu, 15 Jun 2023 04:50:06 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@debian.org>
cc: YunQiang Su <yunqiang.su@cipunited.com>, binutils@sourceware.org, 
    xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH] MIPS: add MT ASE support for micromips32
In-Reply-To: <alpine.DEB.2.21.2305311127190.14435@angie.orcam.me.uk>
Message-ID: <alpine.DEB.2.21.2306150152011.64925@angie.orcam.me.uk>
References: <20230425065626.3587754-1-yunqiang.su@cipunited.com> <alpine.DEB.2.21.2304251059540.58739@angie.orcam.me.uk> <CAKcpw6Wq7p28iV_vd7wuKxYJ7Ar-fz597YtZaRAm9uPPQ5vVtw@mail.gmail.com> <CAKcpw6VnJTH94BO9EY-axkTP67+7zvogCMHCyM2db2H-4ijvQA@mail.gmail.com>
 <alpine.DEB.2.21.2305311127190.14435@angie.orcam.me.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1163.1 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_NUMSUBJECT,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Wed, 31 May 2023, Maciej W. Rozycki wrote:

> > > >  When adding new operand formats you need to document them in
> > > > include/opcode/mips.h.  NB this is not a full review.
> > > >
> > >
> > > Any update?
> > 
> > If no objection, I will commit this patchset.
> 
>  Well, it hasn't been reviewed yet AFAICS.

 I have now reverted this change, as it was committed unapproved.  If you 
want this patch in, then please repost it, get reviewed *and* approved, 
and only then you can commit it.  Thank you.

  Maciej