From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=nY5M=CD=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34])
	by sourceware.org (Postfix) with ESMTP id B63143854E63
	for <binutils@sourceware.org>; Thu, 15 Jun 2023 03:50:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B63143854E63
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 3160A92009C; Thu, 15 Jun 2023 05:50:51 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 2A4D092009B;
	Thu, 15 Jun 2023 04:50:51 +0100 (BST)
Date: Thu, 15 Jun 2023 04:50:51 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@debian.org>
cc: YunQiang Su <yunqiang.su@cipunited.com>, binutils@sourceware.org, 
    xry111@xry111.site, richard.sandiford@arm.com, jiaxun.yang@flygoat.com
Subject: Re: [PATCH] gas: documents .gnu_attribute Tag_GNU_MIPS_ABI_MSA
In-Reply-To: <alpine.DEB.2.21.2305191319480.50034@angie.orcam.me.uk>
Message-ID: <alpine.DEB.2.21.2306150158340.64925@angie.orcam.me.uk>
References: <20230505092716.885338-1-yunqiang.su@cipunited.com> <alpine.DEB.2.21.2305190413420.50034@angie.orcam.me.uk> <CAKcpw6XiPUqnKz4ntUG71-Oh7Nn4mUQ-2A1gqFac3u3534+SrA@mail.gmail.com> <alpine.DEB.2.21.2305191319480.50034@angie.orcam.me.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-1163.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Fri, 19 May 2023, Maciej W. Rozycki wrote:

>  Also your change is actually not obviously correct, because it has a
> defect in formatting: an overlong line that exceeds 79 columns (staying 
> within 74 is preferred where feasible).
> 
>  Finally for a non-native English speaker it's always good to have 
> documentation changes reviewed as this is what our users will read, and 
> the last thing we want is documentation that seems unprofessional.  In 
> this case you have an inconsistency between the two cases: one uses the 
> singular and the other one uses the plural form of the noun, which is bad 
> style.  I find the style of the commit description so-so as well.  Being 
> internal only it's less of a problem, albeit unfixable once pushed.

 I have now committed a fix addressing the defects with your change.  In a 
detailed review, which should have happened *before* your change went in, 
it has turned out the whole paragraph was inconsistent with one covering 
Tag_GNU_MIPS_ABI_FP immediately above.  I have rewritten it accordingly.

  Maciej