From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: david@davidgf.es
Cc: binutils@sourceware.org, David Guillen Fandos <david@davidgf.net>
Subject: Re: [PATCH v2 2/3] Add rotation instructions to MIPS Allegrex CPU
Date: Thu, 15 Jun 2023 04:51:35 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2306150312370.64925@angie.orcam.me.uk> (raw)
In-Reply-To: <20230614000148.10989-3-david@davidgf.es>
On Wed, 14 Jun 2023, david@davidgf.es wrote:
> The Allegrex CPU supports bit rotation instructions as described in the
> MIPS32 release 2 CPU (even though it is a MIPS-2 based CPU).
Just a minor nit about this version.
> diff --git a/gas/testsuite/gas/mips/mips.exp b/gas/testsuite/gas/mips/mips.exp
> index 6dbf2e3746..f4137c5640 100644
> --- a/gas/testsuite/gas/mips/mips.exp
> +++ b/gas/testsuite/gas/mips/mips.exp
> @@ -517,7 +517,7 @@ mips_arch_create r3000 32 mips1 {} \
> mips_arch_create r3900 32 mips1 { gpr_ilocks } \
> { -march=r3900 -mtune=r3900 } { -mmips:3900 } \
> { mipstx39-*-* mipstx39el-*-* }
> -mips_arch_create allegrex 32 mips2 { oddspreg singlefloat } \
> +mips_arch_create allegrex 32 mips2 { oddspreg ror singlefloat } \
You haven't reordered `ror' here as requested with v1. I have done this
for you (and fixed the order for `singlefloat' in 1/3 too, which I missed
previously), but please be more careful in the future. It helps when the
reviewer doesn't have to double-check everything.
I have now committed this change with said modification applied. Thank
you for your contribution.
Maciej
next prev parent reply other threads:[~2023-06-15 3:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 0:01 [PATCH v2 0/3] Add support for MIPS Allegrex david
2023-06-14 0:01 ` [PATCH v2 1/3] Add MIPS Allegrex CPU as a MIPS2-based CPU david
2023-06-15 3:51 ` Maciej W. Rozycki
2023-06-14 0:01 ` [PATCH v2 2/3] Add rotation instructions to MIPS Allegrex CPU david
2023-06-15 3:51 ` Maciej W. Rozycki [this message]
2023-06-14 0:01 ` [PATCH v2 3/3] Add additional missing Allegrex CPU instructions david
2023-06-15 3:51 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2306150312370.64925@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=david@davidgf.es \
--cc=david@davidgf.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).