From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alan Modra <amodra@gmail.com>
Cc: YunQiang Su <wzssyqa@gmail.com>,
YunQiang Su <yunqiang.su@cipunited.com>,
binutils@sourceware.org, Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH v2] MIPS: Don't move __gnu_lto_slim to .scommon
Date: Thu, 20 Jul 2023 10:34:43 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2307201019570.14315@angie.orcam.me.uk> (raw)
In-Reply-To: <ZLj42hHY/Wf/T5DK@squeak.grove.modra.org>
On Thu, 20 Jul 2023, Alan Modra wrote:
> I think the patch is OK, but the same should be applied to another
> place to stop objcopy modifying __gnu_lto_slim.
>
> mips-linux-gnu testcase after running make check:
> binutils/objcopy ld/tmpdir/pr15323a-r.o ld/tmpdir/xxx
> then inspect ld/tmpdir/xxx with readelf.
>
> I'm going to apply the following to mainline, and will also apply to
> the 2.41 branch tomorrow if no one objects.
You are the author of this code, so I guess you know what's going on
here. I still don't understand the circumstances that cause linker.c to
reject this symbol if it's in an SHN_MIPS_SCOMMON rather than SHN_COMMON
section, and the relevant git change descriptions (going back to commit
b794fc1d1c3a ("Warn for ar/nm/ranlib/ld on lto objects without plugin"))
do not explain it, so I'd appreciate if you got me enlightened.
Maciej
next prev parent reply other threads:[~2023-07-20 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 10:36 [PATCH] MIPS: Don't " YunQiang Su
2023-07-03 10:50 ` [PATCH v2] MIPS: Don't move " YunQiang Su
2023-07-05 1:42 ` YunQiang Su
2023-07-13 5:39 ` YunQiang Su
2023-07-19 14:55 ` Maciej W. Rozycki
2023-07-19 17:26 ` YunQiang Su
2023-07-20 9:05 ` Alan Modra
2023-07-20 9:34 ` Maciej W. Rozycki [this message]
2023-07-20 11:23 ` Alan Modra
2023-07-20 14:32 ` Maciej W. Rozycki
2023-07-20 22:44 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2307201019570.14315@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=wzssyqa@gmail.com \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).