From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 8808338393BE for ; Fri, 28 Jul 2023 05:07:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8808338393BE Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id BFB3592009E; Fri, 28 Jul 2023 07:07:24 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id BACE292009C; Fri, 28 Jul 2023 06:07:24 +0100 (BST) Date: Fri, 28 Jul 2023 06:07:24 +0100 (BST) From: "Maciej W. Rozycki" To: Nick Clifton cc: YunQiang Su , binutils@sourceware.org Subject: [committed 12/16] testsuite: Also discard the `.MIPS.options' section In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3488.3 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: From: YunQiang Su Also discard the `.MIPS.options' section, used with n64 MIPS binaries, along with similar other MIPS sections (`.reginfo', `.MIPS.abiflags') not relevant for the test cases concerned, fixing these regressions: mips64-openbsd -FAIL: ld-elf/group3a mips64-openbsd -FAIL: ld-elf/group3b mips64-openbsd -FAIL: Place orphan sections (map file check) mips64-openbsd -FAIL: ld-elf/orphan-region mips64-openbsd -FAIL: ld-elf/orphan mips64-openbsd -FAIL: overlay size (map file check) mips64-openbsd -FAIL: overlay size mips64el-openbsd -FAIL: ld-elf/group3a mips64el-openbsd -FAIL: ld-elf/group3b mips64el-openbsd -FAIL: Place orphan sections (map file check) mips64el-openbsd -FAIL: ld-elf/orphan-region mips64el-openbsd -FAIL: ld-elf/orphan mips64el-openbsd -FAIL: overlay size (map file check) mips64el-openbsd -FAIL: overlay size Co-Authored-By: Maciej W. Rozycki binutils/ * testsuite/binutils-all/strip-3.d: Add `-R .MIPS.options' to the `strip' tag. ld/ * testsuite/ld-elf/group.ld: Also discard `.MIPS.options'. * testsuite/ld-elf/orphan-region.ld: Likewise. * testsuite/ld-elf/orphan.ld: Likewise. * testsuite/ld-mips-elf/got-page-1.ld: Likewise. * testsuite/ld-scripts/overlay-size.t: Likewise. --- binutils/testsuite/binutils-all/strip-3.d | 2 +- ld/testsuite/ld-elf/group.ld | 2 +- ld/testsuite/ld-elf/orphan-region.ld | 2 +- ld/testsuite/ld-elf/orphan.ld | 2 +- ld/testsuite/ld-mips-elf/got-page-1.ld | 2 +- ld/testsuite/ld-scripts/overlay-size.t | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) binutils-yunqiang-test-mips-options.diff Index: binutils-gdb/binutils/testsuite/binutils-all/strip-3.d =================================================================== --- binutils-gdb.orig/binutils/testsuite/binutils-all/strip-3.d +++ binutils-gdb/binutils/testsuite/binutils-all/strip-3.d @@ -1,6 +1,6 @@ #PROG: strip #source: empty.s -#strip: -R .text -R .data -R .bss -R .ARM.attributes -R .reginfo -R .gnu.attributes -R .MIPS.abiflags -R .pdr -R .xtensa.info -R .ARC.attributes -R .note.gnu.property -R .riscv.attributes -R .csky.attributes +#strip: -R .text -R .data -R .bss -R .ARM.attributes -R .reginfo -R .gnu.attributes -R .MIPS.abiflags -R .MIPS.options -R .pdr -R .xtensa.info -R .ARC.attributes -R .note.gnu.property -R .riscv.attributes -R .csky.attributes #readelf: -S --wide #name: strip empty file #target: *-*-linux* *-*-gnu* arm*-*-uclinuxfdpiceabi Index: binutils-gdb/ld/testsuite/ld-elf/group.ld =================================================================== --- binutils-gdb.orig/ld/testsuite/ld-elf/group.ld +++ binutils-gdb/ld/testsuite/ld-elf/group.ld @@ -8,5 +8,5 @@ SECTIONS { . = 0x1000; .text : { *(.text) *(.rodata.brlt) } :image :header - /DISCARD/ : { *(.dropme) *(.reginfo) *(.MIPS.abiflags) } + /DISCARD/ : { *(.dropme) *(.reginfo) *(.MIPS.abiflags) *(.MIPS.options) } } Index: binutils-gdb/ld/testsuite/ld-elf/orphan-region.ld =================================================================== --- binutils-gdb.orig/ld/testsuite/ld-elf/orphan-region.ld +++ binutils-gdb/ld/testsuite/ld-elf/orphan-region.ld @@ -7,5 +7,5 @@ SECTIONS { .text : ALIGN (4) { *(.text) } > region .rodata : ALIGN (4) { *(.rodata) } > region - /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.trampolines) *(.riscv.attributes) } + /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.MIPS.options) *(.trampolines) *(.riscv.attributes) } } Index: binutils-gdb/ld/testsuite/ld-elf/orphan.ld =================================================================== --- binutils-gdb.orig/ld/testsuite/ld-elf/orphan.ld +++ binutils-gdb/ld/testsuite/ld-elf/orphan.ld @@ -6,5 +6,5 @@ SECTIONS .bss : { *(.bss) *(COMMON) } .sbss : { *(.sbss) } .note : { *(.note) } - /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.trampolines) } + /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.MIPS.options) *(.trampolines) } } Index: binutils-gdb/ld/testsuite/ld-mips-elf/got-page-1.ld =================================================================== --- binutils-gdb.orig/ld/testsuite/ld-mips-elf/got-page-1.ld +++ binutils-gdb/ld/testsuite/ld-mips-elf/got-page-1.ld @@ -22,7 +22,7 @@ SECTIONS . = ALIGN (0x400); .bss : { *(.bss .bss.*) } - /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) } + /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.MIPS.options) } } VERSION Index: binutils-gdb/ld/testsuite/ld-scripts/overlay-size.t =================================================================== --- binutils-gdb.orig/ld/testsuite/ld-scripts/overlay-size.t +++ binutils-gdb/ld/testsuite/ld-scripts/overlay-size.t @@ -60,5 +60,5 @@ SECTIONS end_of_data_overlays = . ; . = 0x8000; - /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) } + /DISCARD/ : { *(.reginfo) *(.MIPS.abiflags) *(.MIPS.options) } }