From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: PR30715, VAX: md_create_long_jump
Date: Sat, 12 Aug 2023 19:55:24 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2308121953540.8596@angie.orcam.me.uk> (raw)
In-Reply-To: <ZNdfiWvOzkQQYQCy@squeak.grove.modra.org>
On Sat, 12 Aug 2023, Alan Modra via Binutils wrote:
> >From Kalvis Duckmanton
>
> PR 30715
It would be good having a change description here.
> diff --git a/gas/config/tc-vax.c b/gas/config/tc-vax.c
> index 50adf532a15..d1a2998cdf5 100644
> --- a/gas/config/tc-vax.c
> +++ b/gas/config/tc-vax.c
> @@ -2178,18 +2178,19 @@ md_create_short_jump (char *ptr,
>
> void
> md_create_long_jump (char *ptr,
> - addressT from_addr ATTRIBUTE_UNUSED,
> + addressT from_addr,
> addressT to_addr,
> - fragS *frag,
> - symbolS *to_symbol)
> + fragS *frag ATTRIBUTE_UNUSED,
> + symbolS *to_symbol ATTRIBUTE_UNUSED)
> {
> valueT offset;
>
> - offset = to_addr - S_GET_VALUE (to_symbol);
> - *ptr++ = VAX_JMP; /* Arbitrary jump. */
> - *ptr++ = VAX_ABSOLUTE_MODE;
> + /* account for 1 byte instruction, 1 byte of address specifier and
> + 4 bytes of offset from PC */
This doesn't follow the GNU Coding Standards.
Maciej
next prev parent reply other threads:[~2023-08-12 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-12 10:31 Alan Modra
2023-08-12 18:55 ` Maciej W. Rozycki [this message]
2023-08-14 12:00 Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2308121953540.8596@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).