From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 25A543858404 for ; Tue, 15 Aug 2023 10:14:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 25A543858404 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 7634392009C; Tue, 15 Aug 2023 12:14:35 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 6FEB992009B; Tue, 15 Aug 2023 11:14:35 +0100 (BST) Date: Tue, 15 Aug 2023 11:14:35 +0100 (BST) From: "Maciej W. Rozycki" To: Jan Beulich cc: YunQiang Su , YunQiang Su , paul.hua.gm@gmail.com, binutils@sourceware.org, Alan Modra , Nick Clifton Subject: Re: [PATCH v4 7/7] MIPS: Fix Irix gas testcases In-Reply-To: Message-ID: References: <20230616063412.1715024-1-yunqiang.su@cipunited.com> <20230616063412.1715024-8-yunqiang.su@cipunited.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3488.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 15 Aug 2023, Jan Beulich wrote: > >> 1. Add -mpdr to some cases. > >> Gas doesn't generate .pdr section for Irix objects by default. See > >> `int mips_flag_pdr` in tc-mips.c. > >> > >> 2. Add irix-no-pdr.d. > >> > >> 3. Add and use call-nonpic-1-irix.d for Irix targets. > >> Gas doesn't set O32 flags for Irix objects in e_flags. See > >> `use_e_mips_abi_o32` in gas/configure.ac. > >> > >> 4. Add mips16-e-irix.d: g1 is marked as O on Irix. > >> The Irix 5 and 6 assemblers set the type of any common symbol and > >> any undefined non-function symbol to STT_OBJECT. > >> See `mips_frob_symbol` in tc-mips.c. > > > > @Maciej W. Rozycki ping. > > >From what I can tell, you've addressed all of Maciej's comments on v1. > On that basis this patch is provisionally approved in case he or > Chenghua don't respond within another two weeks time. Btw., it often > helps to send pings To: the person(s) pinged, not just Cc-ing them. This was sent as a part of a patch set that has been superseded by later changes. How do I know it is still relevant? It is the responsibility of the submitter to track changes in the tree and ping and/or resubmit as required. In this case four different classes of changes have been grouped into a single change, as listed in the change description, so this has to be split accordingly into four self-contained patches before I can consider it. Maciej