From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34]) by sourceware.org (Postfix) with ESMTP id 0506A3858025; Mon, 21 Aug 2023 11:14:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0506A3858025 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 4B29192009C; Mon, 21 Aug 2023 13:14:47 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 4507992009B; Mon, 21 Aug 2023 12:14:47 +0100 (BST) Date: Mon, 21 Aug 2023 12:14:47 +0100 (BST) From: "Maciej W. Rozycki" To: Ying Huang cc: libc-alpha , yunqiang.su@oss.cipunited.com, binutils Subject: Re: [PATCH v7] MIPS: Sync elf.h from binutils In-Reply-To: <8725cca2-4c4d-f32d-fc8c-3c6c194c481c@oss.cipunited.com> Message-ID: References: <114fe517229b8cc0e504238f0d8553dd3528f5e9.568cb3db.66b5.4ad3.826b.3b027f1ea47e@feishu.cn> <8725cca2-4c4d-f32d-fc8c-3c6c194c481c@oss.cipunited.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-3488.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 21 Aug 2023, Ying Huang wrote: > Can you help commit  these two patchs? To move forward you need to put the findings from the discussion in the change description, especially given the difficulty to figure out what the correct naming convention for the ELF file header flags is supposed to be. This is so that the next time this information is needed it is readily available rather than requiring chasing in the archives and/or depending on the presence of people who may still remember it as on this occasion. I think it will help if you split the glibc patch into self-contained functional subsets: 1. File header flags -- need documentation, as noted above. 2. SHT_MIPS_ABIFLAGS section type -- obviously correct, no need to elaborate on it. 3. Relocation types -- obviously correct, no need to elaborate on it. 4. GNU attribute stuff -- technically Tag_GNU_MIPS_ABI_FP along with the enumeration it comes with is a bug fix for commit 0bd956720c45 ("Add support for MIPS O32 FPXX and .MIPS.abiflags") which, conservatively, only added definitions actually used by the dynamic loader itself, despite that the header is a part of our public API for the MIPS psABI. I think that either said definitions ought to have been provided internally only or the whole of the API should have been exported at once (this applies to #2 above too). Then the MSA stuff and Val_GNU_MIPS_ABI_FP_NAN2008 as later additions are distinct changes each. I think it is worth mentioning in the inline comment that the latter attribute value has been superseded by EF_MIPS_NAN2008. I'd be tempted to say these would best be three distint changes then, but maybe other people would consider it overly pedantic. Then the binutils change needs to document the switch from E_* to EF_* definitions accordingly. Maciej