From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=WZZq=EO=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id 2E96F3858D28
	for <binutils@sourceware.org>; Tue, 29 Aug 2023 14:46:10 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E96F3858D28
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 32DB892009C; Tue, 29 Aug 2023 16:46:09 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 2C37392009B;
	Tue, 29 Aug 2023 15:46:09 +0100 (BST)
Date: Tue, 29 Aug 2023 15:46:09 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <yunqiang.su@cipunited.com>
cc: binutils@sourceware.org
Subject: Re: [PATCH] GAS/MIPS: Fix testcase module-defer-warn2 for r2+
 triples
In-Reply-To: <20230828043243.2243555-1-yunqiang.su@cipunited.com>
Message-ID: <alpine.DEB.2.21.2308291533200.43104@angie.orcam.me.uk>
References: <20230828043243.2243555-1-yunqiang.su@cipunited.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3488.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Mon, 28 Aug 2023, YunQiang Su wrote:

> When gas is configured with --target=mipsisa32r2el-elf, module-defer-warn2
> will fail:
> 
> /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.s: Assembler messages:
> /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.s:2: Error: `gp=64' used with a 32-bit processor
> extra regexps in /binutils-gdb/gas/testsuite/gas/mips/module-defer-warn2.l starting with "^.*:2: .*: `fp=64' used with a 32-bit.*$"
> EOF from dump.out
> FAIL: mips module-defer-warn2
> 
> The reason is that fp64 is allowed for mips32r2 and onward, so
> the error message `Error: `fp=64' used with a 32-bit fpu` won't emit.

 It has to be a set of separate tests then, because the very purpose of 
the test is to verify all the error messages required are there.  Making 
any optional will defeat the purpose of the test and weaken coverage.

 It seems to me that the best course of action will be converting the test 
to the .d format first, which gives more control, and then split it into 
two, using #skip/#noskip tags as appropriate to select the right one for 
the respective targets.

  Maciej