From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=5MeC=FN=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id 43D423858C78
	for <binutils@sourceware.org>; Fri, 29 Sep 2023 14:32:47 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43D423858C78
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id A09799200BC; Fri, 29 Sep 2023 16:32:46 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 98FD39200BB;
	Fri, 29 Sep 2023 15:32:46 +0100 (BST)
Date: Fri, 29 Sep 2023 15:32:46 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <yunqiang.su@cipunited.com>
cc: YunQiang Su <wzssyqa@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH v2] GAS/MIPS: Fix testcase module-defer-warn2 for r2+
 triples
In-Reply-To: <8aee9403-c552-3a42-5be3-1daa1fddea22@cipunited.com>
Message-ID: <alpine.DEB.2.21.2309291525210.18635@angie.orcam.me.uk>
References: <alpine.DEB.2.21.2308291533200.43104@angie.orcam.me.uk> <20230926112035.2692284-1-yunqiang.su@cipunited.com> <alpine.DEB.2.21.2309290033590.18635@angie.orcam.me.uk> <CAKcpw6WsqzRNkrdEF6oFr1YT9rjssg=CagJiDfGi_PcsSMu-mw@mail.gmail.com>
 <alpine.DEB.2.21.2309291514570.18635@angie.orcam.me.uk> <8aee9403-c552-3a42-5be3-1daa1fddea22@cipunited.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3488.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Fri, 29 Sep 2023, YunQiang Su wrote:

> >   As always one self-contained change per patch please.  Switching to the
> > .d format is one change and fixing R2+ support is another.  So it has to
> > be two separate changes.
> 
> 
> To be make thing more clear, and I am worrying that, the patch can be spilt to
> 3 even:
> 
> 1. switch to .d format
> 
> 2. add "#skip" tag
> 
> 3. add new r2 tests.
> 
> 
> So, if we'd like to split to 2 patches, should they are {{1,2}, 3} or {1, {2,
> 3}}, or should we
> 
> split it to 3 ones?

 Thanks for raising this point, but I think there is no need to add 
"#skip" in a separate step for two reasons:

1. The switch to the .d format preserves the current situation, that is
   the test working correctly for R1- and not working correctly for R2+.  
   There's no need to add "#skip" at this stage.

2. A fix to make the test for R2+ is one functionally self-contained
   change and as documented "#skip"/"#noskip" tags are supposed to be used 
   in pairs (or groups of multiple as required in ternary or wider cases) 
   to cover variants of one specific test, so having "#skip" with no 
   corresponding "#noskip" would in fact be incorrect.  So it has to be 
   made in a single change.

I hope I made myself clear here.

  Maciej