From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <yunqiang.su@cipunited.com>
Cc: binutils@sourceware.org, Nick Clifton <nickc@redhat.com>
Subject: Re: [PATCH] MIPS: fix readelf -S bintest test for N64 triples
Date: Tue, 3 Oct 2023 12:56:49 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2310031242250.2129@angie.orcam.me.uk> (raw)
In-Reply-To: <20230817034046.438336-1-yunqiang.su@cipunited.com>
On Thu, 17 Aug 2023, YunQiang Su wrote:
> MIPS N64 has different section layout. Let's add a new file
> readelf.s-64-tmips.
>
> It can fix this test fail on mips64*-linux-gnuabi64 and mips64*-openbsd.
I actually had to chase readelf.exp and dive into it so as to find out
whether and why this approach is correct. This could have been mentioned
in the description.
Also due to how the test is called it wasn't clear to me from the
description itself what test is actually affected.
> diff --git a/binutils/testsuite/binutils-all/readelf.s-64-tmips b/binutils/testsuite/binutils-all/readelf.s-64-tmips
> new file mode 100644
> index 00000000000..5c19027d0b7
> --- /dev/null
> +++ b/binutils/testsuite/binutils-all/readelf.s-64-tmips
> @@ -0,0 +1,25 @@
> +There are .* section headers, starting at offset .*:
> +
> +Section Headers:
> + +\[Nr\] Name +Type +Address +Offset
> + +Size +EntSize +Flags +Link +Info +Align
> + +\[ 0\] +NULL +0000000000000000 +00000000
> + +0000000000000000 +0000000000000000 +0 +0 +0
> + +\[ 1\] .text +PROGBITS +0000000000000000 +00000040
> + +00000000000000.. +0000000000000000 +AX +0 +0 +.*
> + +\[ 2\] .rel.+text +REL. +0+ +0+.*
> + +000000000000001. +000000000000001. +I +. +1 +8
> + +\[ 3\] .data +PROGBITS +0000000000000000 +000000(48|50)
> + +0000000000000010 +0000000000000000 +WA +0 +0 +.*
> + +\[ 4\] .bss +NOBITS +0000000000000000 +00000060
> + +0000000000000000 +0000000000000000 +WA +0 +0 +.*
> +# .MIPS.options, .MIPS.abiflags, .pdr, .gnu.attributes here
> +#...
> + +\[ .\] .symtab +SYMTAB +0000000000000000 +0+.*
> + +0+.* +0000000000000018 +10 +10 +8
> + +\[10\] .strtab +STRTAB +0000000000000000 +0+.*
> + +0+.* +0000000000000000 .* +0 +0 +1
> + +\[11\] .shstrtab +STRTAB +0000000000000000 +[0-9a-f]+
> + +00000000000000.. +0000000000000000 .* +0 +0 +.*
> +Key to Flags:
> +#...
Since the scope for this dump is so narrow there is no need to
wildcard-match output produced. It can be an exact match for easier
detection of unwanted changes in output, just as the original readelf.s
dump used to be.
Also #... at the end is unusual, #pass can be used to terminate matching
successfully right away rather than wading through the rest of output only
to ignore it.
I have committed the change with these updates made for you, posted
separately, thank you for your contribution.
Maciej
next prev parent reply other threads:[~2023-10-03 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 3:40 YunQiang Su
2023-08-28 3:53 ` YunQiang Su
2023-09-28 3:45 ` YunQiang Su
2023-10-03 11:56 ` Maciej W. Rozycki [this message]
2023-10-03 23:02 ` YunQiang Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2310031242250.2129@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=yunqiang.su@cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).