From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by sourceware.org (Postfix) with ESMTP id 373BD3858D1E for ; Sat, 7 Oct 2023 19:23:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 373BD3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk Received: by angie.orcam.me.uk (Postfix, from userid 500) id 8C93492009C; Sat, 7 Oct 2023 21:23:07 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 817F292009B; Sat, 7 Oct 2023 20:23:07 +0100 (BST) Date: Sat, 7 Oct 2023 20:23:07 +0100 (BST) From: "Maciej W. Rozycki" To: Michael Eager cc: Neal Frager , binutils@sourceware.org, ibai.erkiaga-elorza@amd.com, nagaraju.mekala@amd.com, mark.hatle@amd.com, sadanand.mutyala@amd.com, appa.rao.nali@amd.com, vidhumouli.hunsigida@amd.com, luca.ceresoli@bootlin.com, Nick Clifton Subject: Re: [PATCH v2 1/1] opcodes: microblaze: Add new bit-field instructions In-Reply-To: <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> Message-ID: References: <20231005125103.1330807-1-neal.frager@amd.com> <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-1163.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 6 Oct 2023, Michael Eager wrote: > > This patch has been tested for years of AMD Xilinx Yocto > > releases as part of the following patch set: > > > > https://github.com/Xilinx/meta-xilinx/tree/master/meta-microblaze/recipes-devtools/binutils/binutils > > > > Signed-off-by: nagaraju > > Signed-off-by: Ibai Erkiaga > > Signed-off-by: Neal Frager > > Committed. Yet it has caused numerous regressions: microblaze-elf +FAIL: unordered .debug_info references to .debug_ranges microblaze-elf +FAIL: binutils-all/pr26548 microblaze-elf +FAIL: readelf -Wwi pr26548e (reason: unexpected output) microblaze-elf +FAIL: readelf --debug-dump=loc locview-1 (reason: unexpected output) microblaze-elf +FAIL: readelf --debug-dump=loc locview-2 (reason: unexpected output) microblaze-elf +FAIL: readelf -wiaoRlL dw5 microblaze-elf +FAIL: readelf -wi dwarf-attributes (reason: unexpected output) microblaze-elf +FAIL: readelf -wKis -P debuglink (reason: unexpected output) microblaze-elf +FAIL: readelf --debug-dump=links --debug-dump=no-follow-links dwo microblaze-elf +FAIL: DWARF2 1 microblaze-elf +FAIL: DWARF2 2 microblaze-elf +FAIL: DWARF2 3 microblaze-elf +FAIL: DWARF2 5 microblaze-elf +FAIL: DWARF2 6 microblaze-elf +FAIL: DWARF2 7 microblaze-elf +FAIL: DWARF2 11 microblaze-elf +FAIL: DWARF2 12 microblaze-elf +FAIL: DWARF2 13 microblaze-elf +FAIL: DWARF2 14 microblaze-elf +FAIL: DWARF2 15 microblaze-elf +FAIL: DWARF2 16 microblaze-elf +FAIL: DWARF2 17 microblaze-elf +FAIL: DWARF2 18 microblaze-elf +FAIL: DWARF2 19 microblaze-elf +FAIL: DWARF2_20: debug ranges ignore non-code sections microblaze-elf +FAIL: DWARF2 21 microblaze-elf +FAIL: DWARF5 .loc 0 microblaze-elf +FAIL: DWARF4 CU microblaze-elf +FAIL: DWARF5 CU microblaze-elf +FAIL: Check line table is produced with .nops microblaze-elf +FAIL: line number entries for section changes inside .irp microblaze-elf +FAIL: line number entries for .macro expansions microblaze-elf +FAIL: line number entries for expansions of .macro coming from .include microblaze-elf +FAIL: lns-duplicate microblaze-elf +FAIL: lns-common-1 microblaze-elf +FAIL: ld-elf/pr22450 They all seem to follow a similar pattern, e.g: exited abnormally with 1, output:readelf: Warning: Corrupt unit length (got 0x4e00004e expected at most 0x4e) in section .debug_info FAIL: DWARF2 1 or: exited abnormally with 0, output:readelf: Warning: Corrupt unit length (got 0x20000020 expected at most 0x20) in section .debug_info FAIL: Check line table is produced with .nops Configured with: $ /path/to/configure --disable-nls --disable-gdb --disable-gdbserver --disable-gprofng --disable-libbacktrace --disable-libdecnumber --disable-readline --disable-sim --enable-obsolete --enable-plugins --build=powerpc64le-linux --target=microblaze-elf Just reporting in case it's useful as it has popped up in unrelated verification; I won't do anything else here. NB I've skimmed over the change and noticed it does not follow the GNU Coding Standards in many places, most prominently in `get_field_imm5width' and `get_field_rfsl', but also elsewhere (which is easy to spot looking through the diff). Maciej