From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=2a+S=FX=orcam.me.uk=macro@sourceware.org>
Received: from angie.orcam.me.uk (angie.orcam.me.uk [IPv6:2001:4190:8020::34])
	by sourceware.org (Postfix) with ESMTP id E274D3858D1E
	for <binutils@sourceware.org>; Mon,  9 Oct 2023 13:32:44 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E274D3858D1E
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=orcam.me.uk
Received: by angie.orcam.me.uk (Postfix, from userid 500)
	id 6A31192009C; Mon,  9 Oct 2023 15:32:43 +0200 (CEST)
Received: from localhost (localhost [127.0.0.1])
	by angie.orcam.me.uk (Postfix) with ESMTP id 6279C92009B;
	Mon,  9 Oct 2023 14:32:43 +0100 (BST)
Date: Mon, 9 Oct 2023 14:32:43 +0100 (BST)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: "Frager, Neal" <neal.frager@amd.com>
cc: Michael Eager <eager@eagercon.com>, 
    "binutils@sourceware.org" <binutils@sourceware.org>, 
    "Erkiaga Elorza, Ibai" <ibai.erkiaga-elorza@amd.com>, 
    "Mekala, Nagaraju" <nagaraju.mekala@amd.com>, 
    "Hatle, Mark" <mark.hatle@amd.com>, 
    "Mutyala, Sadanand" <sadanand.mutyala@amd.com>, 
    "Nali, Appa Rao" <appa.rao.nali@amd.com>, 
    "Hunsigida, Vidhumouli" <vidhumouli.hunsigida@amd.com>, 
    "luca.ceresoli@bootlin.com" <luca.ceresoli@bootlin.com>, 
    Nick Clifton <nickc@redhat.com>
Subject: RE: [PATCH v2 1/1] opcodes: microblaze: Add new bit-field
 instructions
In-Reply-To: <CH2PR12MB5004990FBAFA59546BDA9A63F0CEA@CH2PR12MB5004.namprd12.prod.outlook.com>
Message-ID: <alpine.DEB.2.21.2310091416360.48714@angie.orcam.me.uk>
References: <20231005125103.1330807-1-neal.frager@amd.com> <5d2ce973-6287-db3d-fc82-966914f765a7@eagercon.com> <alpine.DEB.2.21.2310072009350.20732@angie.orcam.me.uk> <66d26b55-0457-9ed6-50af-0f5feeb057b0@eagercon.com>
 <CH2PR12MB5004990FBAFA59546BDA9A63F0CEA@CH2PR12MB5004.namprd12.prod.outlook.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3488.6 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,KAM_INFOUSMEBIZ,KAM_LAZY_DOMAIN_SECURITY,KAM_SHORT,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

On Mon, 9 Oct 2023, Frager, Neal wrote:

> > Add test cases for new instructions.
> > Fix GNU Coding Standard issues.
> > Run binutils test suite.
> 
> Thank you for feedback.  Could you possibly help me with resolving the 
> GNU coding standard issues and the build issue Maciej is reporting?

 See: <https://www.gnu.org/prep/standards/standards.html#Formatting> and 
<https://www.gnu.org/prep/standards/standards.html#Comments> for the 
relevant parts of the GNU Coding Standards (you're welcome to review the 
whole document).

 To reproduce the regressions configure your binutils with the command I 
provided and run the testsuite using `make check'.  Test logs will be in 
binutils/binutils.log, gas/testsuite/gas.log and ld/ld.log (there will be 
corresponding .sum files with test summaries).  There may be preexisting 
issues, but you have the list of failures to watch out for in my previous 
message.  You need to make sure no new failures have been introduced by 
your change.

 As I write I came by these issues by chance in unrelated verification 
and I won't provide further feedback as I have no interest in the 
MicroBlaze port and I cannot afford the time to be distracted.  Michael, 
the port maintainer may be able to provide you with further guidance.

 HTH,

  Maciej