From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: YunQiang Su <syq@gcc.gnu.org>
Cc: Nick Clifton <nickc@redhat.com>,
binutils@sourceware.org, xry111@xry111.site
Subject: Re: [PATCH] MIPS/Gas: Support .L/$ as the mark of local symbol
Date: Wed, 21 Feb 2024 13:32:48 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2402211313000.61493@angie.orcam.me.uk> (raw)
In-Reply-To: <20240205101427.2862503-1-syq@gcc.gnu.org>
On Mon, 5 Feb 2024, YunQiang Su wrote:
> In as.texi, there are lines:
> A local symbol is any symbol beginning with certain local
> label prefixes. By default, the local label prefix is
> @samp{.L} for ELF systems or @samp{L} for traditional a.out
> systems, but each target may have its own set of local
> label prefixes.
>
> Let's support it for MIPS:
> 1) For OldABI, GCC uses "$" to mark local symbols, and
> for NewABI, ".L" is used. So let's support both for
> OldABI, and ".L" only for NewABI.
> 2) Emit an fatal error, if a local symbol is used, while
> not defined, just like LLVM does.
I gather you want to avoid a case of an undefined reference making it to
output for a symbol whose name suggests its a local label, right?
But that seems like material for the generic part of GAS rather than the
MIPS backend only (and then specifically SVR4 PIC only and not non-PIC or
VxWorks, according to your code as submitted), so that all targets behave
consistently, and I can't see e.g. i386 GAS doing it.
So a question raises: what problem are you trying to solve? Can you give
us a piece of code that you think is handled incorrectly by GAS, and why?
Maciej
next prev parent reply other threads:[~2024-02-21 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 10:14 YunQiang Su
2024-02-21 8:50 ` YunQiang Su
2024-02-21 13:32 ` Maciej W. Rozycki [this message]
2024-02-21 14:09 ` YunQiang Su
2024-02-21 14:47 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2402211313000.61493@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
--cc=syq@gcc.gnu.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).