From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Jan Beulich <jbeulich@suse.com>
Cc: Binutils <binutils@sourceware.org>, Chenghua Xu <paul.hua.gm@gmail.com>
Subject: Re: [PATCH 07/11] gas: consistently drop trailing whitespace when scrubbing
Date: Mon, 1 Jul 2024 12:05:15 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2407011159190.43454@angie.orcam.me.uk> (raw)
In-Reply-To: <f516750a-50d7-4b5c-8db4-856b84e9fb1e@suse.com>
On Mon, 1 Jul 2024, Jan Beulich wrote:
> >> In the MIPS testsuite adjustments I wasn't sure how exactly to make the
> >> necessary changes: I could also have zapped the two blanks each, but
> >> then I wondered why they were part of the expectations in the first
> >> place.
> >
> > Please do.
>
> Done locally; I won't post a v2 just for this, though.
Thank you, and agreed.
> > The only reason I can think of why the patterns are such as they are is
> > that they need to match the output as it has been produced. It made no
> > sense to make whitespace matching optional when said whitespace is always
> > there.
>
> But the purpose of those tests isn't the _exact_ output that gas would
> produce, is it? The presence / absence of whitespace in most tests
> really is entirely unrelated to what is being tested. Just to mention
> it ...
Of course, but something has to be placed there as the pattern to match
against and taking the message produced literally, whitespace or not, is
the simplest and most obvious choice.
Also think of the MIPS tests as coverage for your good work; is there any
other?
Maciej
next prev parent reply other threads:[~2024-07-01 11:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 13:15 [PATCH 00/11] gas: scrubber adjustments Jan Beulich
2024-06-28 13:17 ` [PATCH 01/11] gas: there's no scrubber state 12 Jan Beulich
2024-06-28 13:17 ` [PATCH 02/11] gas: drop scrubber state -2 Jan Beulich
2024-06-28 13:18 ` [PATCH 03/11] gas: multi-byte warning adjustments Jan Beulich
2024-06-28 13:18 ` [PATCH 04/11] gas: don't open-code IS_WHITESPACE() / IS_NEWLINE() Jan Beulich
2024-06-28 13:19 ` [PATCH 05/11] gas: pre-init the scrubber's lex[] Jan Beulich
2024-07-01 1:45 ` Hans-Peter Nilsson
2024-07-01 6:02 ` Jan Beulich
2024-06-28 13:20 ` [PATCH 06/11] gas: re-work tic6x scrubber special case Jan Beulich
2024-06-28 13:22 ` [PATCH 07/11] gas: consistently drop trailing whitespace when scrubbing Jan Beulich
2024-06-28 13:53 ` Maciej W. Rozycki
2024-07-01 5:58 ` Jan Beulich
2024-07-01 11:05 ` Maciej W. Rozycki [this message]
2024-07-03 13:42 ` Michael Matz
2024-06-28 13:23 ` [PATCH 08/11] Arm: correct macro use in gas testsuite Jan Beulich
2024-06-28 13:24 ` [PATCH 09/11] Arm: relax gas testsuite whitespace expectations Jan Beulich
2024-06-28 13:26 ` [PATCH 10/11] aarch64: " Jan Beulich
2024-06-28 13:31 ` [PATCH WIP/RFC 11/11] gas: have scrubber retain more whitespace Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2407011159190.43454@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
--cc=paul.hua.gm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).