Re: [PATCH 06/15] MIPS/GAS/test: Adjust LD for multi-target testing

["Maciej W. Rozycki" <macro@linux-mips.org>]

On Mon, 18 Oct 2010, Maciej W. Rozycki wrote:

> > The patch seems to contain some parts that make the matching more strict
> > and some that make it less so.  The former look good, but I'm less sure
> > about the latter.  For example, with something like:
> > 
> > [0-9a-f]+ <[^>]*> lw   a0,(0|4096)\(at\)
> > [      ]*[0-9a-f]+: [A-Z0-9_]*LO[A-Z0-9_]*     \.data(\+0xfffff000)?
> > 
> > the difference seems relatively important: on some targets the addend
> > must be in-place, on some it mustn't be.  It might make more sense
> > to have separate dumps for the two cases.  However, that sort of
> > difference is probably picked up by other tests too, so the risk
> > might not be great.
> 
>  This is certainly strictier than the original that for the record was:
> 
> [0-9a-f]+ <[^>]*> lw	a0,0\(at\)
> [ 	]*[0-9a-f]+: [A-Z0-9_]*LO[A-Z0-9_]*	.data.*
> 
> (and obviously failed for ECOFF because of the different in-place addend).

 Wrong quotation actually, taken from the bit-rotten ld-ilocks.d -- the 
typical patterns this addresses were ones like these in ld.d:

[0-9a-f]+ <[^>]*> lw	a0,[-0-9]+\(at\)
[ 	]*[0-9a-f]+: [A-Z0-9_]*LO[A-Z0-9_]*	.data.*

that have been clearly adjusted for ECOFF and matched any in-place as well 
as relocation addends.  The new patterns are no less strict and then the 
rest of my consideration applies.

  Maciej