* [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1
@ 2010-10-03 19:41 Maciej W. Rozycki
2010-10-10 10:27 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2010-10-03 19:41 UTC (permalink / raw)
To: binutils
[-- Attachment #1: Type: TEXT/PLAIN, Size: 3424 bytes --]
Hi,
The biggest in this series, this change extends the LD test to cover
other doubleword operations, namely SD, L.D, S.D, LDC1 and SDC1. There
are subtle differences among them, including load-delay slots and the use
or not of the AT register, that in turn also makes non-trivially different
code sequences to be chosen for n64, so I think it'll be good to have them
covered all.
As a side effect it tests some macro and symbol facilities -- the ability
to override an instruction mnemonic with a macro and define a symbol to
refer to a processor register.
2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
gas/testsuite/
* gas/mips/ld.s: Adjust to let SD, L.D, S.D, LDC1 and SDC1
macros to be tested, according to the "tsd", "tl_d", "ts_d",
"tldc1" and "tsdc1" symbols.
* gas/mips/sd.d: New test.
* gas/mips/ecoff@sd.d: Likewise, ECOFF version.
* gas/mips/mips1@ecoff@sd.d: Likewise, MIPS I/ECOFF version.
* gas/mips/r3000@ecoff@sd.d: Likewise, R3000/ECOFF version.
* gas/mips/r3900@ecoff@sd.d: Likewise, R3900/ECOFF version.
* gas/mips/mips2@ecoff@sd.d: Likewise, MIPS II/ECOFF version.
* gas/mips/mips32@ecoff@sd.d: Likewise, MIPS32/ECOFF version.
* gas/mips/mips32r2@ecoff@sd.d: Likewise, MIPS32r2/ECOFF
version.
* gas/mips/sd-f.d: New test.
* gas/mips/ecoff@sd-f.d: Likewise, ECOFF version.
* gas/mips/mips1@ecoff@sd-f.d: Likewise, MIPS I/ECOFF version.
* gas/mips/r3000@ecoff@sd-f.d: Likewise, R3000/ECOFF version.
* gas/mips/r3900@ecoff@sd-f.d: Likewise, R3900/ECOFF version.
* gas/mips/mips2@ecoff@sd-f.d: Likewise, MIPS II/ECOFF version.
* gas/mips/mips32@ecoff@sd-f.d: Likewise, MIPS32/ECOFF version.
* gas/mips/mips32r2@ecoff@sd-f.d: Likewise, MIPS32r2/ECOFF
version.
* gas/mips/l_d.d: New test.
* gas/mips/mips1@l_d.d: Likewise, MIPS I version.
* gas/mips/r3000@l_d.d: Likewise, R3000 version.
* gas/mips/r3900@l_d.d: Likewise, R3900 version.
* gas/mips/l_d-f.d: New test.
* gas/mips/mips1@l_d-f.d: Likewise, MIPS I version.
* gas/mips/r3000@l_d-f.d: Likewise, R3000 version.
* gas/mips/r3900@l_d-f.d: Likewise, R3900 version.
* gas/mips/s_d.d: New test.
* gas/mips/mips1@s_d.d: Likewise, MIPS I version.
* gas/mips/r3000@s_d.d: Likewise, R3000 version.
* gas/mips/r3900@s_d.d: Likewise, R3900 version.
* gas/mips/s_d-f.d: New test.
* gas/mips/mips1@s_d-f.d: Likewise, MIPS I version.
* gas/mips/r3000@s_d-f.d: Likewise, R3000 version.
* gas/mips/r3900@s_d-f.d: Likewise, R3900 version.
* gas/mips/ldc1.d: New test.
* gas/mips/ldc1-f.d: Likewise.
* gas/mips/sdc1.d: Likewise.
* gas/mips/sdc1-f.d: Likewise.
* gas/mips/sd-n32.d: Likewise.
* gas/mips/sd-n64.d: Likewise.
* gas/mips/sd-f-n32.d: Likewise.
* gas/mips/sd-f-n64.d: Likewise.
* gas/mips/l_d-n32.d: Likewise.
* gas/mips/l_d-n64.d: Likewise.
* gas/mips/l_d-f-n32.d: Likewise.
* gas/mips/l_d-f-n64.d: Likewise.
* gas/mips/s_d-n32.d: Likewise.
* gas/mips/s_d-n64.d: Likewise.
* gas/mips/s_d-f-n32.d: Likewise.
* gas/mips/s_d-f-n64.d: Likewise.
* gas/mips/ldc1-n32.d: Likewise.
* gas/mips/ldc1-n64.d: Likewise.
* gas/mips/ldc1-f-n32.d: Likewise.
* gas/mips/ldc1-f-n64.d: Likewise.
* gas/mips/sdc1-n32.d: Likewise.
* gas/mips/sdc1-n64.d: Likewise.
* gas/mips/sdc1-f-n32.d: Likewise.
* gas/mips/sdc1-f-n64.d: Likewise.
* gas/mips/mips.exp: Run the new tests.
OK to apply?
Maciej
binutils-2.20.51-20100925-mips-gas-test-xd.patch
[Patch attached compressed due to its size.]
[-- Attachment #2: Type: APPLICATION/X-BZIP2, Size: 6347 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1
2010-10-03 19:41 [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1 Maciej W. Rozycki
@ 2010-10-10 10:27 ` Richard Sandiford
2010-10-24 10:37 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2010-10-10 10:27 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: binutils
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> 2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
>
> gas/testsuite/
> * gas/mips/ld.s: Adjust to let SD, L.D, S.D, LDC1 and SDC1
> macros to be tested, according to the "tsd", "tl_d", "ts_d",
> "tldc1" and "tsdc1" symbols.
> * gas/mips/sd.d: New test.
> * gas/mips/ecoff@sd.d: Likewise, ECOFF version.
> * gas/mips/mips1@ecoff@sd.d: Likewise, MIPS I/ECOFF version.
> * gas/mips/r3000@ecoff@sd.d: Likewise, R3000/ECOFF version.
> * gas/mips/r3900@ecoff@sd.d: Likewise, R3900/ECOFF version.
> * gas/mips/mips2@ecoff@sd.d: Likewise, MIPS II/ECOFF version.
> * gas/mips/mips32@ecoff@sd.d: Likewise, MIPS32/ECOFF version.
> * gas/mips/mips32r2@ecoff@sd.d: Likewise, MIPS32r2/ECOFF
> version.
> * gas/mips/sd-f.d: New test.
> * gas/mips/ecoff@sd-f.d: Likewise, ECOFF version.
> * gas/mips/mips1@ecoff@sd-f.d: Likewise, MIPS I/ECOFF version.
> * gas/mips/r3000@ecoff@sd-f.d: Likewise, R3000/ECOFF version.
> * gas/mips/r3900@ecoff@sd-f.d: Likewise, R3900/ECOFF version.
> * gas/mips/mips2@ecoff@sd-f.d: Likewise, MIPS II/ECOFF version.
> * gas/mips/mips32@ecoff@sd-f.d: Likewise, MIPS32/ECOFF version.
> * gas/mips/mips32r2@ecoff@sd-f.d: Likewise, MIPS32r2/ECOFF
> version.
> * gas/mips/l_d.d: New test.
> * gas/mips/mips1@l_d.d: Likewise, MIPS I version.
> * gas/mips/r3000@l_d.d: Likewise, R3000 version.
> * gas/mips/r3900@l_d.d: Likewise, R3900 version.
> * gas/mips/l_d-f.d: New test.
> * gas/mips/mips1@l_d-f.d: Likewise, MIPS I version.
> * gas/mips/r3000@l_d-f.d: Likewise, R3000 version.
> * gas/mips/r3900@l_d-f.d: Likewise, R3900 version.
> * gas/mips/s_d.d: New test.
> * gas/mips/mips1@s_d.d: Likewise, MIPS I version.
> * gas/mips/r3000@s_d.d: Likewise, R3000 version.
> * gas/mips/r3900@s_d.d: Likewise, R3900 version.
> * gas/mips/s_d-f.d: New test.
> * gas/mips/mips1@s_d-f.d: Likewise, MIPS I version.
> * gas/mips/r3000@s_d-f.d: Likewise, R3000 version.
> * gas/mips/r3900@s_d-f.d: Likewise, R3900 version.
> * gas/mips/ldc1.d: New test.
> * gas/mips/ldc1-f.d: Likewise.
> * gas/mips/sdc1.d: Likewise.
> * gas/mips/sdc1-f.d: Likewise.
> * gas/mips/sd-n32.d: Likewise.
> * gas/mips/sd-n64.d: Likewise.
> * gas/mips/sd-f-n32.d: Likewise.
> * gas/mips/sd-f-n64.d: Likewise.
> * gas/mips/l_d-n32.d: Likewise.
> * gas/mips/l_d-n64.d: Likewise.
> * gas/mips/l_d-f-n32.d: Likewise.
> * gas/mips/l_d-f-n64.d: Likewise.
> * gas/mips/s_d-n32.d: Likewise.
> * gas/mips/s_d-n64.d: Likewise.
> * gas/mips/s_d-f-n32.d: Likewise.
> * gas/mips/s_d-f-n64.d: Likewise.
> * gas/mips/ldc1-n32.d: Likewise.
> * gas/mips/ldc1-n64.d: Likewise.
> * gas/mips/ldc1-f-n32.d: Likewise.
> * gas/mips/ldc1-f-n64.d: Likewise.
> * gas/mips/sdc1-n32.d: Likewise.
> * gas/mips/sdc1-n64.d: Likewise.
> * gas/mips/sdc1-f-n32.d: Likewise.
> * gas/mips/sdc1-f-n64.d: Likewise.
> * gas/mips/mips.exp: Run the new tests.
OK, thanks. The number of combinations and files is becoming a bit
daunting, but that's the nature of the beast that is MIPS. I agree
all these things should be tested.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1
2010-10-10 10:27 ` Richard Sandiford
@ 2010-10-24 10:37 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2010-10-24 10:37 UTC (permalink / raw)
To: Richard Sandiford; +Cc: binutils
On Sun, 10 Oct 2010, Richard Sandiford wrote:
> > gas/testsuite/
> > * gas/mips/ld.s: Adjust to let SD, L.D, S.D, LDC1 and SDC1
> > macros to be tested, according to the "tsd", "tl_d", "ts_d",
> > "tldc1" and "tsdc1" symbols.
> > * gas/mips/sd.d: New test.
> > * gas/mips/ecoff@sd.d: Likewise, ECOFF version.
> > * gas/mips/mips1@ecoff@sd.d: Likewise, MIPS I/ECOFF version.
> > * gas/mips/r3000@ecoff@sd.d: Likewise, R3000/ECOFF version.
> > * gas/mips/r3900@ecoff@sd.d: Likewise, R3900/ECOFF version.
> > * gas/mips/mips2@ecoff@sd.d: Likewise, MIPS II/ECOFF version.
> > * gas/mips/mips32@ecoff@sd.d: Likewise, MIPS32/ECOFF version.
> > * gas/mips/mips32r2@ecoff@sd.d: Likewise, MIPS32r2/ECOFF
> > version.
> > * gas/mips/sd-f.d: New test.
> > * gas/mips/ecoff@sd-f.d: Likewise, ECOFF version.
> > * gas/mips/mips1@ecoff@sd-f.d: Likewise, MIPS I/ECOFF version.
> > * gas/mips/r3000@ecoff@sd-f.d: Likewise, R3000/ECOFF version.
> > * gas/mips/r3900@ecoff@sd-f.d: Likewise, R3900/ECOFF version.
> > * gas/mips/mips2@ecoff@sd-f.d: Likewise, MIPS II/ECOFF version.
> > * gas/mips/mips32@ecoff@sd-f.d: Likewise, MIPS32/ECOFF version.
> > * gas/mips/mips32r2@ecoff@sd-f.d: Likewise, MIPS32r2/ECOFF
> > version.
> > * gas/mips/l_d.d: New test.
> > * gas/mips/mips1@l_d.d: Likewise, MIPS I version.
> > * gas/mips/r3000@l_d.d: Likewise, R3000 version.
> > * gas/mips/r3900@l_d.d: Likewise, R3900 version.
> > * gas/mips/l_d-f.d: New test.
> > * gas/mips/mips1@l_d-f.d: Likewise, MIPS I version.
> > * gas/mips/r3000@l_d-f.d: Likewise, R3000 version.
> > * gas/mips/r3900@l_d-f.d: Likewise, R3900 version.
> > * gas/mips/s_d.d: New test.
> > * gas/mips/mips1@s_d.d: Likewise, MIPS I version.
> > * gas/mips/r3000@s_d.d: Likewise, R3000 version.
> > * gas/mips/r3900@s_d.d: Likewise, R3900 version.
> > * gas/mips/s_d-f.d: New test.
> > * gas/mips/mips1@s_d-f.d: Likewise, MIPS I version.
> > * gas/mips/r3000@s_d-f.d: Likewise, R3000 version.
> > * gas/mips/r3900@s_d-f.d: Likewise, R3900 version.
> > * gas/mips/ldc1.d: New test.
> > * gas/mips/ldc1-f.d: Likewise.
> > * gas/mips/sdc1.d: Likewise.
> > * gas/mips/sdc1-f.d: Likewise.
> > * gas/mips/sd-n32.d: Likewise.
> > * gas/mips/sd-n64.d: Likewise.
> > * gas/mips/sd-f-n32.d: Likewise.
> > * gas/mips/sd-f-n64.d: Likewise.
> > * gas/mips/l_d-n32.d: Likewise.
> > * gas/mips/l_d-n64.d: Likewise.
> > * gas/mips/l_d-f-n32.d: Likewise.
> > * gas/mips/l_d-f-n64.d: Likewise.
> > * gas/mips/s_d-n32.d: Likewise.
> > * gas/mips/s_d-n64.d: Likewise.
> > * gas/mips/s_d-f-n32.d: Likewise.
> > * gas/mips/s_d-f-n64.d: Likewise.
> > * gas/mips/ldc1-n32.d: Likewise.
> > * gas/mips/ldc1-n64.d: Likewise.
> > * gas/mips/ldc1-f-n32.d: Likewise.
> > * gas/mips/ldc1-f-n64.d: Likewise.
> > * gas/mips/sdc1-n32.d: Likewise.
> > * gas/mips/sdc1-n64.d: Likewise.
> > * gas/mips/sdc1-f-n32.d: Likewise.
> > * gas/mips/sdc1-f-n64.d: Likewise.
> > * gas/mips/mips.exp: Run the new tests.
>
> OK, thanks. The number of combinations and files is becoming a bit
> daunting, but that's the nature of the beast that is MIPS. I agree
> all these things should be tested.
That's still far from complete coverage, but will at least test a
reasonable subset with these changes. We can see how things need to be
addressed as we discover them. Applied, finally. Thanks.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-03 19:41 [PATCH 15/15] MIPS/GAS/test: Cover SD, L.D, S.D, LDC1 and SDC1 Maciej W. Rozycki
2010-10-10 10:27 ` Richard Sandiford
2010-10-24 10:37 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).