* [PATCH] MIPS/GAS/test: Simplify MIPS16 enabling
@ 2010-10-03 19:41 Maciej W. Rozycki
2010-10-04 20:38 ` Richard Sandiford
0 siblings, 1 reply; 3+ messages in thread
From: Maciej W. Rozycki @ 2010-10-03 19:41 UTC (permalink / raw)
To: binutils
Hi,
MIPS16 testing should only be enabled for ELF. This change guarantees it
while simplifying the whole arrangement at the same time.
2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
gas/testsuite/
* gas/mips/mips.exp: Simplify MIPS16 enabling.
OK to apply?
Maciej
binutils-2.20.51-20100925-mips-gas-test-mips16.patch
Index: binutils-2.20.51/gas/testsuite/gas/mips/mips.exp
===================================================================
--- binutils-2.20.51.orig/gas/testsuite/gas/mips/mips.exp
+++ binutils-2.20.51/gas/testsuite/gas/mips/mips.exp
@@ -404,12 +404,12 @@ if { [istarget mips*-*-vxworks*] } {
run_dump_test "vxworks1-el"
run_dump_test "vxworks1-xgot-el"
} elseif { [istarget mips*-*-*] } {
- set no_mips16 0
set elf [expr [istarget *-*-elf*] || [istarget *-*-irix5*] || [istarget *-*-irix6* ] || [istarget *-*-linux*] || [istarget *-*-netbsd*] ]
set ecoff [expr [istarget *-*-ecoff*] || [istarget *-*-ultrix*] || [istarget *-*-irix\[1-4\]*] ]
set aout [expr [istarget *-*-bsd*] || [istarget *-*-openbsd*] ]
set addr32 [expr [istarget mipstx39*-*-*] || [istarget mips-*-linux*] || [istarget mipsel-*-linux*] || [istarget mips*-*-ecoff]]
set has_newabi [expr [istarget *-*-irix6*] || [istarget mips64*-*-linux*]]
+ set no_mips16 [expr !$elf]
if { [istarget "mips*-*-*linux*"] || [istarget "mips*-sde-elf*"] } then {
set tmips "t"
@@ -421,9 +421,6 @@ if { [istarget mips*-*-vxworks*] } {
} {
set el ""
}
- if { $ecoff } {
- set no_mips16 1
- }
if { $no_mips16 } {
mips_arch_destroy mips16
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/GAS/test: Simplify MIPS16 enabling
2010-10-03 19:41 [PATCH] MIPS/GAS/test: Simplify MIPS16 enabling Maciej W. Rozycki
@ 2010-10-04 20:38 ` Richard Sandiford
2010-10-24 10:55 ` Maciej W. Rozycki
0 siblings, 1 reply; 3+ messages in thread
From: Richard Sandiford @ 2010-10-04 20:38 UTC (permalink / raw)
To: Maciej W. Rozycki; +Cc: binutils
"Maciej W. Rozycki" <macro@linux-mips.org> writes:
> 2010-10-03 Maciej W. Rozycki <macro@linux-mips.org>
>
> gas/testsuite/
> * gas/mips/mips.exp: Simplify MIPS16 enabling.
OK, thanks.
I'll try to review the others soon.
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS/GAS/test: Simplify MIPS16 enabling
2010-10-04 20:38 ` Richard Sandiford
@ 2010-10-24 10:55 ` Maciej W. Rozycki
0 siblings, 0 replies; 3+ messages in thread
From: Maciej W. Rozycki @ 2010-10-24 10:55 UTC (permalink / raw)
To: Richard Sandiford; +Cc: binutils
On Mon, 4 Oct 2010, Richard Sandiford wrote:
> > gas/testsuite/
> > * gas/mips/mips.exp: Simplify MIPS16 enabling.
>
> OK, thanks.
Applied as well, thanks.
Maciej
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-24 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-03 19:41 [PATCH] MIPS/GAS/test: Simplify MIPS16 enabling Maciej W. Rozycki
2010-10-04 20:38 ` Richard Sandiford
2010-10-24 10:55 ` Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).