From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Jan-Benedict Glaw <jbglaw@lug-owl.de>
Cc: Hans-Peter Nilsson <hp@bitrange.com>, binutils@sourceware.org
Subject: Re: [PATCH] VAX/BFD: Omit PLT slots for local symbols
Date: Mon, 06 Aug 2012 10:14:00 -0000 [thread overview]
Message-ID: <alpine.LFD.2.00.1208052345450.613@eddie.linux-mips.org> (raw)
In-Reply-To: <20120715215705.GZ25491@lug-owl.de>
On Sun, 15 Jul 2012, Jan-Benedict Glaw wrote:
> > bfd/
> > * elf32-vax.c (elf_vax_adjust_dynamic_symbol): Don't allocate
> > PLT slots for local symbols.
> >
> > ld/testsuite/
> > * ld-vax-elf/plt-local-lib.dd: New test.
> > * ld-vax-elf/plt-local-lib.ld: New test linker script.
> > * ld-vax-elf/plt-local-lib.s: New test source.
> > * ld-vax-elf/plt-local.dd: New test.
> > * ld-vax-elf/plt-local.ld:New test linker script.
> > * ld-vax-elf/plt-local.s: New test source.
> > * ld-vax-elf/plt-local-hidden-pic.s: New test source.
> > * ld-vax-elf/plt-local-rehidden-pic.s: New test source.
> > * ld-vax-elf/vax-elf.exp: New test script.
>
> Even if the test cases wiring-up can be done in one way or another and
> both have their pros and cons, lets stop the discussion here. First of
> all, I'm quite happy that there are actually new test cases. Editing
> another list to let it run is a second step, but ... I think we can
> manage that.
Nothing's going to be cast in stone here, I'll be happy to update or even
turn this test case (and any following) upside down entirely once we've
come up with a better solution.
> Please apply.
Thanks for your review, I have trivially refreshed this change and
regression retested it with no problems spotted. Applied now. Apologies
for the latency.
Maciej
prev parent reply other threads:[~2012-08-05 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 23:30 Maciej W. Rozycki
2012-05-08 4:12 ` Hans-Peter Nilsson
2012-07-11 0:04 ` Maciej W. Rozycki
2012-07-11 3:29 ` Hans-Peter Nilsson
2012-07-15 21:57 ` Jan-Benedict Glaw
2012-08-06 10:14 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1208052345450.613@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=binutils@sourceware.org \
--cc=hp@bitrange.com \
--cc=jbglaw@lug-owl.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).