* [committed] MIPS/GAS: Remove stale `prev_reloc_op_frag' variable
@ 2020-07-21 1:01 Maciej W. Rozycki
0 siblings, 0 replies; only message in thread
From: Maciej W. Rozycki @ 2020-07-21 1:01 UTC (permalink / raw)
To: binutils
Ever since commit 4d7206a284ee ("Rework MIPS macro relaxation, fix string
merging bug"), <https://sourceware.org/ml/binutils/2004-01/msg00248.html>,
`prev_reloc_op_frag' has only been set and never used. Remove it then.
gas/
* config/tc-mips.c (prev_reloc_op_frag): Remove variable.
(my_getSmallExpression): Adjust accordingly.
---
No regressions across my usual MIPS targets; committed.
---
gas/config/tc-mips.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
binutils-mips-gas-prev_reloc_op_frag.diff
Index: binutils/gas/config/tc-mips.c
===================================================================
--- binutils.orig/gas/config/tc-mips.c
+++ binutils/gas/config/tc-mips.c
@@ -889,11 +889,6 @@ struct mips_hi_fixup
static struct mips_hi_fixup *mips_hi_fixup_list;
-/* The frag containing the last explicit relocation operator.
- Null if explicit relocations have not been used. */
-
-static fragS *prev_reloc_op_frag;
-
/* Map mips16 register numbers to normal MIPS register numbers. */
static const unsigned int mips16_to_32_reg_map[] =
@@ -14720,12 +14715,8 @@ my_getSmallExpression (expressionS *ep,
expr_end = str;
- if (reloc_index != 0)
- {
- prev_reloc_op_frag = frag_now;
- for (i = 0; i < reloc_index; i++)
- reloc[i] = reversed_reloc[reloc_index - 1 - i];
- }
+ for (i = 0; i < reloc_index; i++)
+ reloc[i] = reversed_reloc[reloc_index - 1 - i];
return reloc_index;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-21 1:01 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 1:01 [committed] MIPS/GAS: Remove stale `prev_reloc_op_frag' variable Maciej W. Rozycki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).