From: Michael Matz <matz@suse.de>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH 2/2] x86-64: Use MAXPAGESIZE for the relro segment alignment
Date: Tue, 15 Feb 2022 14:08:53 +0000 (UTC) [thread overview]
Message-ID: <alpine.LSU.2.20.2202151345230.17157@wotan.suse.de> (raw)
In-Reply-To: <20220215011026.738505-2-hjl.tools@gmail.com>
Hello,
On Mon, 14 Feb 2022, H.J. Lu via Binutils wrote:
> Adjust x86-64 linker tests after reverting
>
> commit 31b4d3a16f200bf04db8439a63b72bba7af4e1be
> Author: Alan Modra <amodra@gmail.com>
> Date: Thu Feb 3 08:57:47 2022 +1030
>
> PR28824, relro security issues, x86 keep COMMONPAGESIZE relro
>
> to use MAXPAGESIZE for the end of the relro segment alignment, like other
> ELF targets.
>
> --- a/ld/testsuite/ld-x86-64/pr14207.d
> +++ b/ld/testsuite/ld-x86-64/pr14207.d
> @@ -11,9 +11,9 @@ There are 4 program headers, starting at offset 64
> Program Headers:
> Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align
> LOAD 0x000000 0x0000000000000000 0x0000000000000000 0x000150 0x000150 R 0x200000
> - LOAD 0x000b.8 0x0000000000200b.8 0x0000000000200b.8 0x0004.0 0x000c.8 RW 0x200000
> - DYNAMIC 0x000b.0 0x0000000000200b.0 0x0000000000200b.0 0x0001.0 0x0001.0 RW 0x8
> - GNU_RELRO 0x000b.8 0x0000000000200b.8 0x0000000000200b.8 0x0004.0 0x0004.8 R 0x1
> + LOAD 0x1ffb.8 0x00000000003ffb.8 0x00000000003ffb.8 0x0004.0 0x000c.8 RW 0x200000
> + DYNAMIC 0x1ffb.0 0x00000000003ffb.0 0x00000000003ffb.0 0x0001.0 0x0001.0 RW 0x8
> + GNU_RELRO 0x1ffb.8 0x00000000003ffb.8 0x00000000003ffb.8 0x0004.0 0x0004.8 R 0x1
This change implies that the filesize increased by 2MB (and I verified
this to be the case). I don't think that's a good trade-off. E.g. I have
about 3500 binaries in /usr/bin/ alone. That linker change translates to
an overall increase of 7 Gigabytes filesize. Right now all the files
therein are about 1GB.
So, please!
Ciao,
Michael.
next prev parent reply other threads:[~2022-02-15 14:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 1:10 [PATCH 1/2] Revert "PR28824, relro security issues, x86 keep COMMONPAGESIZE relro" H.J. Lu
2022-02-15 1:10 ` [PATCH 2/2] x86-64: Use MAXPAGESIZE for the relro segment alignment H.J. Lu
2022-02-15 14:08 ` Michael Matz [this message]
2022-02-15 14:41 ` H.J. Lu
2022-02-15 14:57 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.20.2202151345230.17157@wotan.suse.de \
--to=matz@suse.de \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).