From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <matz@suse.de>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d])
 by sourceware.org (Postfix) with ESMTPS id 97EE438582BF
 for <binutils@sourceware.org>; Mon,  8 Aug 2022 12:49:33 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 97EE438582BF
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
 by smtp-out2.suse.de (Postfix) with ESMTP id BB48D1FDC3;
 Mon,  8 Aug 2022 12:49:32 +0000 (UTC)
Received: from wotan.suse.de (wotan.suse.de [10.160.0.1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by relay2.suse.de (Postfix) with ESMTPS id B33442C141;
 Mon,  8 Aug 2022 12:49:32 +0000 (UTC)
Received: by wotan.suse.de (Postfix, from userid 10510)
 id AB0416080; Mon,  8 Aug 2022 12:49:32 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by wotan.suse.de (Postfix) with ESMTP id A9B37607E;
 Mon,  8 Aug 2022 12:49:32 +0000 (UTC)
Date: Mon, 8 Aug 2022 12:49:32 +0000 (UTC)
From: Michael Matz <matz@suse.de>
To: Jan Beulich <jbeulich@suse.com>
cc: Binutils <binutils@sourceware.org>
Subject: Re: [PATCH 06/12] revert "x86: Also pass -P to $(CPP) when processing
 i386-opc.tbl"
In-Reply-To: <146313cd-154f-4001-05a8-6b25a90a14d2@suse.com>
Message-ID: <alpine.LSU.2.20.2208081245030.13939@wotan.suse.de>
References: <b45b6c58-e06a-2cef-ad97-0cb7956d3fd5@suse.com>
 <146313cd-154f-4001-05a8-6b25a90a14d2@suse.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 12:49:34 -0000

Hello,

On Fri, 5 Aug 2022, Jan Beulich via Binutils wrote:

> This reverts commit 384f368958f2a5bb083660e58e5f8a010e6ad429, which
> broke i386-gen's emitting of diagnostics. As a replacement to address
> the original issue of newer gcc no longer splicing lines when dropping
> the line continuation backslashes, switch to using + as the line
> continuation character, doing the line splicing in i386-gen.

I will note that all occurrences of the line continuation character are 
within the various <> templates, never in the opcodes themself.  So their 
content is all bracketed, and there's no reason why they should even be 
considered to be single-lined.  So all of this should be possible to be 
fixed in parse_template() alone, and then i386-opc.tbl wouldn't need any 
continuation characters at all.


Ciao,
Michael.