From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Vbe6=7C=suse.de=matz@sourceware.org>
Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d])
	by sourceware.org (Postfix) with ESMTPS id 2B5D83858D38
	for <binutils@sourceware.org>; Fri, 10 Mar 2023 14:13:35 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2B5D83858D38
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
	by smtp-out2.suse.de (Postfix) with ESMTP id 5E27920656;
	Fri, 10 Mar 2023 14:13:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1678457614; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9JmzRG/e/zqwD2G8ZWVj0WMZ1NwoYtVWLC82e03GOQA=;
	b=t5NZzGvr1QFTO5EYkEFXGeV4/BAa+dtHQwU25dWdYMNLSAgSi1MLtWbpooDpu/Jdjgdlk2
	eLwInWeNYb1DYXuJKUi4dxd4x0Yb4IHd2bnvw8wN23/a/v6N9dzi1hN2j2d+nCvrvXhpmn
	xLBKZbSI9Qm3avJhPYEghb+zJC97v+g=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1678457614;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
	 mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=9JmzRG/e/zqwD2G8ZWVj0WMZ1NwoYtVWLC82e03GOQA=;
	b=S2q8DZpWna22sZOl4TX6bYuU1q342szvAlc8Mw62foB9hhB2Glx34VSq0o5QhjS4QwI16v
	Laklrzggf8/mGADA==
Received: from wotan.suse.de (wotan.suse.de [10.160.0.1])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by relay2.suse.de (Postfix) with ESMTPS id 4D6182C141;
	Fri, 10 Mar 2023 14:13:34 +0000 (UTC)
Received: by wotan.suse.de (Postfix, from userid 10510)
	id 340D066AE; Fri, 10 Mar 2023 14:13:34 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by wotan.suse.de (Postfix) with ESMTP id 32DEA66A3;
	Fri, 10 Mar 2023 14:13:34 +0000 (UTC)
Date: Fri, 10 Mar 2023 14:13:34 +0000 (UTC)
From: Michael Matz <matz@suse.de>
To: binutils@emagii.com
cc: binutils@sourceware.org, nickc@redhat.com
Subject: Re: [PATCH v1 0/7 SECTOR: Support aligning to flash sector
 boundary
In-Reply-To: <20230310000817.751962-1-binutils@emagii.com>
Message-ID: <alpine.LSU.2.20.2303101409100.16810@wotan.suse.de>
References: <20230310000817.751962-1-binutils@emagii.com>
User-Agent: Alpine 2.20 (LSU 67 2015-01-07)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <binutils.sourceware.org>

Hello,

On Fri, 10 Mar 2023, Ulf Samuelsson via Binutils wrote:

> This can be used later to align a sector to the flash boundary using the 
> 
> ALIGN_SECTOR command in an output sector.

Please consider implementing new features in terms of existing ones.  For 
instance there is already an 'ALIGN' expression, that either takes dot or 
an arbitrary expression to align, to a certain given value.  Your new 
feature is basically just a special value for such alignment, so it makes 
sense to specify _that_ instead of a new top-level expression.  So, 
consider accepting something like:

   ALIGN(TOSECTOR)
   ALIGN(expr, TOSECTOR)

so that one would write

   . = ALIGN(TOSECTOR)

as usual with alignment of dot.  The 'TOSECTOR' token would be the new 
thing and make it do what you wanted with ALIGN_SECTOR.


Ciao,
Michael.