Re: [PATCH v1 0/3 CHIP: Support vendor script libraries

[Michael Matz <matz@suse.de>]

Hello,

On Tue, 14 Mar 2023, Ulf Samuelsson via Binutils wrote:

> Introduce the CHIP command for non-MRI script files.
> 
> The motivation is that you want to simplify supporting microcontrollers.
> You want include files that define the addresses for all peripherals
> and the memory/bank organisation.

Makes sense, but why is it not enough to use "INCLUDE(<chip>.inc)" in the 
linker script and passing -L$LD_VENDOR_DIR/<chip> on the linker command 
line?

The harcoding of environment variables seems very specific, especially 
for the unsuffixed PROJ_DIR (which definitely looks more like something 
for the build system to add).  So, if you really want to avoid cmdline 
additions, maybe introducing a way to specify envvar names for the 
SEARCH_DIR directive would be better?

Like

  SEARCH_DIR($LD_VENDOR_DIR/at91sam7s64)
  INCLUDE(at91sam7s64.inc)

Support for envvars in SEARCH_DIR (and possibly INCLUDE as well) would 
seem somewhat useful in its own right I think.  (Yes, it would conflict 
with potential current use of '$' as a starter for a filename 
component, in which case quoting can be used to disambiguate).


Ciao,
Michael.