From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37527 invoked by alias); 17 Feb 2020 21:06:42 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 37518 invoked by uid 89); 17 Feb 2020 21:06:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL autolearn=no version=3.3.1 spammy=stephen, Stephen X-HELO: d.mail.sonic.net Received: from d.mail.sonic.net (HELO d.mail.sonic.net) (64.142.111.50) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Feb 2020 21:06:41 +0000 Received: from auge (75-25-121-24.lightspeed.snvaca.sbcglobal.net [75.25.121.24]) (authenticated bits=0) by d.mail.sonic.net (8.15.1/8.15.1) with ESMTPSA id 01HL6ZI5022699 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 17 Feb 2020 13:06:36 -0800 Date: Mon, 17 Feb 2020 21:06:00 -0000 From: Stephen Casner To: Alan Modra cc: binutils@sourceware.org Subject: Re: Problem with ld for PDP-11 In-Reply-To: Message-ID: References: <20200213002635.GA29647@bubble.grove.modra.org> User-Agent: Alpine 2.21.9999 (OSX 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SW-Source: 2020-02/txt/msg00416.txt.bz2 I have submitted bug 25569 with a patch for this proposed fix. -- Steve On Fri, 14 Feb 2020, Stephen Casner wrote: > On Thu, 13 Feb 2020, Alan Modra wrote: > > > The correct fix then is to add a check that the original data size was > > odd. That might not be easy as you may have lost the original data > > size by the time this code runs. The AOUT code is a bit of a mess. > > Here's an alternative idea, if it would not be a logical scope > violation to access the "where" member: check abfd->where to see if > an odd byte has been written, and if so add a padding byte. > > > Oh, and if there is no data then it's the text section that might need > > extending. > > That should not be a concern because PDP11 instruction must always be > a multiple of words long. > > -- Steve