From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by sourceware.org (Postfix) with ESMTPS id DB2223853541 for ; Wed, 8 Jun 2022 06:11:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DB2223853541 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-30-Ho07uwBCNNS6gFoHqINkAg-1; Wed, 08 Jun 2022 08:11:20 +0200 X-MC-Unique: Ho07uwBCNNS6gFoHqINkAg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReUx+YqWwRsdRLmkeJC7/tKiCu7HsFNovbENxsmW3Xm6ryE+BeQ+TBer50XbIU5Q5boIrTMDLzUB54wlDxbzE+E424aYqiHXmNB5MEbv8AeWQwCcojW2uAtmslYvdZb0R173XnjWGwqfmsKYwnikeOFvolh+qjwsxft8XeOjSA7YGydoJS7uKFWiSEASBAqbcz9D9LPhvp5ii2AONG76nAaYgeimLRgCwKw2zkUBWL2HuLAsUWWemb49hewxlTcbiFdilJvUGuTPg6X9nFdVlS+4vchOjExSoSUDfulAd7EeTwk26lkYeKefpxgppGbFLKAo3i/Uyc6+gZyqa5BZlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZyuyqUCIJBUV0CRJiDJbgv1R9B6fywhGmlE6VPLujZA=; b=UQvZM5aNpl3P30NC6sfkrFvCWJoAddJQtWjiYAca0WZRQisTXVTKV/1n+lsvHgju+0zvfybylhWpEiMeWMQwoltJSGO14+dKDqbI1Xi4dD3CX3IhO/2APbolQ1Et0KIJPUWeYZvPbpnOQ+E4RpdM1h0zj0GTaeBT+C99KZMZKvq4Nbg38IZ3ewwCDIQNd0eQ/XvFlkGRM0ZG3oUDTj3ypzdQk9z/DiQ+6KNlB9RPofTBxbw5zAJwFhlNr2w+HMuOY+uLkCa6lGW8XYSCRB2jllAHlGL0tCWv2pbW5bzsQS+1lHtfifZguDnKZBGWtJNASfh27mHrOeQnlHavwnEtCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB3136.eurprd04.prod.outlook.com (2603:10a6:802:10::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.12; Wed, 8 Jun 2022 06:11:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 06:11:18 +0000 Message-ID: Date: Wed, 8 Jun 2022 08:11:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] readelf: Replace xmalloc with malloc in slurp_relr_relocs Content-Language: en-US To: Marcus Nilsson References: <20220607212342.671687-1-brainbomb@gmail.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20220607212342.671687-1-brainbomb@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0047.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b708d423-51d0-4e9d-ab8e-08da4915b346 X-MS-TrafficTypeDiagnostic: VI1PR04MB3136:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0btfKRlGMJL/MPs5myuNWLyX0LXxfhx/la0Wcij9KVuUVAHc2i56YQYQSeizwwK1HTIvwjU18Gt85YTlH6Nk8jrSJJPcB8ZmI4crpAydqeQ/1BGWWornczxHGqd+Y8JXUrZfjSszVNNF9xaFGWyJFLfW13+v7usTq7nf0dDTHsFF/lYCHzsdZD1xevyUkpUhn6+rqojh0Gl/NCI1b34/l3b+VNCxTJ/LeooJu8RZtAK+WtgtcfIeywimS+KRvIQ7jR0JgvX04DvoFh6ibyUZlSkKKuv1J7B+tRktbv/A6vyQ20eKP9O5nD3ujdaWVqdUo58PblGNskAaM+ZwRffmbrsM+596sPRASlKHanR3ZLNG82aRzWisdfHBlY//iKzWvoSGNStQA/nL2En2Y12RbeIw7/yC4LIwMtrIRP7md7SCvAETyl+6fNR7rmVKFbSaDg4Ye8yeio1qg4Yd98ysdsLYPk8Sw7IBodSQMDGJocHoD241mWeb7fLgUeMclIw24pTTxRq9wt5meiJf2HtbQw8wYRl2+JAs3d9Kq030nt4UQ2cwd4iJ6fPbFc2+vktCd4gvWMKsnc+k3/b3mbmUrQZEEv0EY86OgoUdcB0qCwgWt97oqvH5tvbxFy9qJl1kb4Zxie+K5s3y8V5pwqFfwaQBhjWjWykglp8Y7p/hDWuZwGpxnzNS8vUeho9Z1N/F1Ob7A+Xd4R1a5PjMyR0Zkfc8giBhBMnICK4BxBsgJW0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VE1PR04MB6560.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6916009)(316002)(8936002)(5660300002)(8676002)(66476007)(66946007)(66556008)(86362001)(6506007)(186003)(6666004)(6512007)(26005)(4326008)(2616005)(508600001)(6486002)(31696002)(38100700002)(2906002)(31686004)(4744005)(36756003)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXFRZ25Jais1d3RncDlZSXVGRE1Gdmd3RGJNZ2JwRk5SN0pZNCtYbVMwb2kx?= =?utf-8?B?U3lTdVRhUzBQSDVFeVdUSUVmVWI3WFVUTXBZeWxGbnRiSm9OYVdZU3c2Z0lS?= =?utf-8?B?c2Z0QXA4NkdZcmN4Mk9vZlhLTFNhQnlJa09uc0NpaVNaeDFITGVXQXAyMWwz?= =?utf-8?B?Q21ua2xvdjd1VVhIeUZiaUsweXZJSlN2c1BWK3dST3g2ajZ1REZ2eHBIVzQ5?= =?utf-8?B?WnZXUExGbUY4eFQ2dXNYblhRN2NsTlJlamlvVFhVdlFZcUVrN2JacUluYmwr?= =?utf-8?B?VDdaVVpqdVlBVkJqWDkxR1dFQ3NEb3pONE00S1VBUGo1WU1lamgxbGJrMnQ2?= =?utf-8?B?a0REajI4MEcxdG10Z0lJVXpEWHoxaHNESVo1eTVCMHNjWUdpekhjam9tWlp3?= =?utf-8?B?THFTYzlIYzhiZnIrZ1V6UVpHQ3o4UmRWbjY1NXNJeERUdERZajdhS0s1blcv?= =?utf-8?B?Nlg1WDhJQU9LRlBpTWxXWEg3NVFLbytlUWtNSlA5T1ZUT1UrOEtPazJ0VkFq?= =?utf-8?B?UFkyRlVpUGlGcTVDWm1OUkRPbUZrOFFPTlRyUE5Xdy85L0VqM1cvNmI0TFZN?= =?utf-8?B?OEJsN1gvMVhPRVdWczhGcEYzVmJYZGZUWUI0WS9Sb21LTkNEYzd4VTdndCs2?= =?utf-8?B?clJZajhOc2hBRUVkdTFPQWF4djI5Z0hOTGNDSEpLUkpvUUhLV1AxNjFXOFR1?= =?utf-8?B?TXpTdmFhQVFsYVJvU1VYa2lvMG9OaWJaZEdhVDZOOTBrWWh2cWwreHZrR2ht?= =?utf-8?B?d2drVWJraG84VlZxNVlIdjB4dUwxTVRRNDFWeHpmcGh0ZjY5ekRoZ1p2NEEw?= =?utf-8?B?ZlVKWFcrelk3dk14SE00T05xaDF1OWI0bUdvNDNUVDlBWGQxeXp2VVJLYkhR?= =?utf-8?B?dEY0MHZ2RzczT3BINWs3T2ZYWUcrRjZabDcyaVh4aUV0Nldsd2xWencyRnlT?= =?utf-8?B?djVkSWhNalJOeG9GQTJiS1FZZXRFN2c0ZjRpSG5lTmJTMkNROFJCNVY3a2Q0?= =?utf-8?B?YkFwQTEwYXpkWDFvVmUyM3ZHOFJvL1lzRll6Z2dpUGc1WndjZnBQSlFRaStl?= =?utf-8?B?Z2hSbHhYVkZUOGRrNHdzVnN0TmJDcExGQWNnQnZ4emE5V0VmV1Uzd1lEQk94?= =?utf-8?B?YTVRczdUd2k4RGxXeGhZTzlsRDJ4bTJsMDRMRUQ5dHY1UkFZNzRKeFpiUG9Z?= =?utf-8?B?bk1vRUJvcVo4OW9reEtOcDJtM1kyQSt2TXpNb056Y2hlSUlDbWdiMnE4R3VH?= =?utf-8?B?V1BRTzhRY3J0L2pxRmxBU3RCN1VVZ0c4WGMxMWRtL2xFSU02OWVlOE1KWm5u?= =?utf-8?B?MmR5MlRkMkR2cFBER09ra1MrVTNxYkhLY2h3Wk1ERWdtTWZIWEtqRlB6eTdE?= =?utf-8?B?dXM4YVE5V3QrUC9ES1o5b0VNQS9yWjZINk1FUXdOYTFxU3phQlgwMHN4WW51?= =?utf-8?B?QmlCMGRSOWRkV2dXVGJpOWIxQTRLUGdvU2REN2cvQU1aUXJucGlSNjhUdnpk?= =?utf-8?B?ZTB4WVJtbEh1M044TTl5cTB4Slo0L00zcnZiYWdEUUh3Tnh3NllTSGpBQjhD?= =?utf-8?B?OThhVTBZbUhzYWZ0aDR3VExwQXRscTNoUHZxTGhlZXRpeXJpZTFoNTBqNEs1?= =?utf-8?B?NVMwc1NtMENoNHJRbXpRUW9yWnoxb2dRUDM2dnl4Z2w3MXdrOFRqSXVNSUlR?= =?utf-8?B?ZXJqaUNDRC9rYnJvdjMzbWZYcE95aDlZeEtTdFNRNHhQcGl0VFdhK2Y2eE5z?= =?utf-8?B?OXhxUmYzaE5GU2lZNDM0L25UQ0VCTTUwSXYzRXRpMEw0TTBCWVArOWRxV3hF?= =?utf-8?B?ZHZHeTVrd0l1WWNuaGh0Z0ZRSzJDUWhzZHc4VXV4RGZxVFFPN0pMeDFhT1JL?= =?utf-8?B?VW01ZnA3NENUcnEyWlJFR1ZLaWlBRG1OWmtwRXVSMXJFcE9YM3NYNWErNXNk?= =?utf-8?B?V01wQXlEOVRxZFRESGd1TGJGWURBZWVJdU9vS1RINE9FNmFEa2orZlVEb1Ey?= =?utf-8?B?VEIzaUVFZi82Yit3VGxWakpBZ0dyelZaOE1ETGdpNjh0WTlUM0w2Vzl4Sk5F?= =?utf-8?B?WUNhZjFNNDV1RGRuQ1krZXRDSVFZdlkrR3lMcGR6cHNzSUxlbzI3c2l6YnhT?= =?utf-8?B?MlVCQmMrZCtFUEh4OEcwVk9TVnFoenk4c29lRXRFZkJubXc0WGJITmtqMUhU?= =?utf-8?B?MnEwbmZ4Qmk1THVhN0wvRUloRzRjUmtTUGM5WitucE5wYkdvVkVaNGJoSE1Q?= =?utf-8?B?azR5OUdZVmxuTFB5djAxOHgyalVYaUl1d2ZGcVNOR082UE9pWFc5UXdkVWpP?= =?utf-8?B?OTNVUUVGWWVHL0kwSDdZbElxNHVwTjM3OEg1Y0IxSFBqTWthTnJXQT09?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b708d423-51d0-4e9d-ab8e-08da4915b346 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jun 2022 06:11:18.0833 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FjacTwJJPfJjFslXwU9HWhmSvHkkqk46hv2Zv4GCkE4qoTzeMN/IPDOH+UHo18mMTesSv2obsCMH0W3SnzGFZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3136 X-Spam-Status: No, score=-3032.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 06:11:25 -0000 On 07.06.2022 23:23, Marcus Nilsson via Binutils wrote: > Using xmalloc makes the null check redundant since failing allocation > will exit the program. Instead use malloc and let the error be > conveyed up the call chain. > > binutils/ChangeLog: > * readelf.c: (slurp_relr_relocs) Use malloc instead of xmalloc > when allocating space for relocations. OK. Jan