From: Georg-Johann Lay <avr@gjlay.de>
To: binutils@sourceware.org, Nick Clifton <nickc@redhat.com>
Subject: [avr, patch 1/1] Addendum to PR31124: Don't PROVIDE __flmap_init_label
Date: Tue, 30 Jan 2024 14:53:18 +0100 [thread overview]
Message-ID: <b086ae27-bb91-4597-9392-63bfd0b41f35@gjlay.de> (raw)
In-Reply-To: <2e7671e3-8cfd-4a86-94df-31985365fb1b@gjlay.de>
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
PR31124: Addendum: Remove PROVIDE of __flmap_init_label, __flmap.
Supply these symbols as computed by the linker scripts, even when there
are weak definitions.
ld/
PR 31124
* scripttempl/avr.sc (__flmap, __flmap_init_label): Remove PROVIDE.
[-- Attachment #2: pr31124-flmap-noprovide.diff --]
[-- Type: text/x-patch, Size: 989 bytes --]
diff --git a/ld/scripttempl/avr.sc b/ld/scripttempl/avr.sc
index 00ff49aacf4..a70c09e29c1 100644
--- a/ld/scripttempl/avr.sc
+++ b/ld/scripttempl/avr.sc
@@ -358,8 +358,8 @@ EOF
if test -z "${HAVE_FLMAP}" && test -n "${RELOCATING}"; then
cat <<EOF
-PROVIDE (__flmap_init_label = DEFINED(__flmap_noinit_start) ? __flmap_noinit_start : 0) ;
-PROVIDE (__flmap = DEFINED(__flmap) ? __flmap : 0) ;
+__flmap_init_label = DEFINED(__flmap_noinit_start) ? __flmap_noinit_start : 0 ;
+__flmap = DEFINED(__flmap) ? __flmap : 0 ;
EOF
fi
@@ -368,7 +368,7 @@ if test -n "${HAVE_FLMAP}"; then
cat <<EOF
${RELOCATING+
-PROVIDE (__flmap_init_label = DEFINED(__flmap_init_start) ? __flmap_init_start : 0) ;
+__flmap_init_label = DEFINED(__flmap_init_start) ? __flmap_init_start : 0 ;
/* User can specify position of .rodata in flash (LMA) by supplying
__RODATA_FLASH_START__ or __flmap, where the former takes precedence. */
__RODATA_FLASH_START__ = DEFINED(__RODATA_FLASH_START__)
prev parent reply other threads:[~2024-01-30 13:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 13:37 [avr, patch 0/1] Addendum to PR3124: " Georg-Johann Lay
2024-01-30 13:44 ` Nick Clifton
2024-01-31 8:43 ` [avr, patch 0/1] Addendum to PR31124: " Georg-Johann Lay
2024-01-31 11:25 ` Nick Clifton
2024-01-30 13:53 ` Georg-Johann Lay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b086ae27-bb91-4597-9392-63bfd0b41f35@gjlay.de \
--to=avr@gjlay.de \
--cc=binutils@sourceware.org \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).