From: Xi Ruoyao <xry111@xry111.site>
To: mengqinggang <mengqinggang@loongson.cn>, binutils@sourceware.org
Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn,
liuzhensong@loongson.cn, i.swmail@xen0n.name,
maskray@google.com, cailulu@loongson.cn
Subject: Re: [PATCH 4/5] LoongArch: Remove "elf_seg_map (info->output_bfd) == NULL" relaxation condition
Date: Mon, 30 Oct 2023 13:14:02 +0800 [thread overview]
Message-ID: <b10f18c384d1cd8f676ce15611062b2c0b6d9936.camel@xry111.site> (raw)
In-Reply-To: <23e214a61579094d9367f7b089f9e139378f4b5e.camel@xry111.site>
Ping.
Is there any reason holding this patch?
On Thu, 2023-10-19 at 22:04 +0800, Xi Ruoyao wrote:
> Hi,
>
> I don't know BFD very well, but IMO this should be applied and
> backported to 2.41 ASAP because "not relaxing shared objects" is a
> very
> serious issue.
>
> On Fri, 2023-10-13 at 16:24 +0800, mengqinggang wrote:
> > ---
> > bfd/elfnn-loongarch.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
> > index 47334943fde..38a25b63813 100644
> > --- a/bfd/elfnn-loongarch.c
> > +++ b/bfd/elfnn-loongarch.c
> > @@ -3747,6 +3747,11 @@ loongarch_relax_pcala_addi (bfd *abfd,
> > asection *sec,
> > uint32_t pca = bfd_get (32, abfd, contents + rel_hi->r_offset);
> > uint32_t add = bfd_get (32, abfd, contents + rel_lo->r_offset);
> > uint32_t rd = pca & 0x1f;
> > +
> > + /* Because previous sections' relax, output_offset may increase
> > and need to
> > + be updated before relax. But it update after relax in
> > + size_input_section defaultly, so we manually updating here.
> > */
> > + sec->output_offset = sec->output_section->size;
> > bfd_vma pc = sec_addr (sec) + rel_hi->r_offset;
> > const uint32_t addi_d = 0x02c00000;
> > const uint32_t pcaddi = 0x18000000;
> > @@ -3889,7 +3894,6 @@ loongarch_elf_relax_section (bfd *abfd,
> > asection *sec,
> > || sec->sec_flg0
> > || (sec->flags & SEC_RELOC) == 0
> > || sec->reloc_count == 0
> > - || elf_seg_map (info->output_bfd) == NULL
> > || (info->disable_target_specific_optimizations
> > && info->relax_pass == 0)
> > /* The exp_seg_relro_adjust is enum phase_enum (0x4),
>
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-10-30 5:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 8:24 [PATCH 1/5] LoongArch: Fix ld --no-relax bug mengqinggang
2023-10-13 8:24 ` [PATCH 2/5] LoongArch: Directly delete relaxed instuctions, not use R_LARCH_DELETE relocation mengqinggang
2023-10-13 8:24 ` [PATCH 3/5] LoongArch: Multiple relax_trip in one relax_pass mengqinggang
2023-10-13 8:24 ` [PATCH 4/5] LoongArch: Remove "elf_seg_map (info->output_bfd) == NULL" relaxation condition mengqinggang
2023-10-19 14:04 ` Xi Ruoyao
2023-10-30 5:14 ` Xi Ruoyao [this message]
2023-10-30 8:00 ` mengqinggang
2023-11-16 0:03 ` Xi Ruoyao
2023-11-16 2:06 ` mengqinggang
2023-10-13 8:24 ` [PATCH 5/5] LoongArch: Modify link_info.relax_pass from 3 to 2 mengqinggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b10f18c384d1cd8f676ce15611062b2c0b6d9936.camel@xry111.site \
--to=xry111@xry111.site \
--cc=binutils@sourceware.org \
--cc=cailulu@loongson.cn \
--cc=chenglulu@loongson.cn \
--cc=i.swmail@xen0n.name \
--cc=liuzhensong@loongson.cn \
--cc=maskray@google.com \
--cc=mengqinggang@loongson.cn \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).