From: Jan Beulich <jbeulich@suse.com>
To: "Clément Chigot" <chigot@adacore.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] windres: add quotes around preprocessor cmd if needed
Date: Tue, 28 Jun 2022 11:00:18 +0200 [thread overview]
Message-ID: <b117237e-f665-2da8-64f4-53018e2a09b1@suse.com> (raw)
In-Reply-To: <CAJ307EinOMV+ECLDTvkKzTdn39HfDERb28CsWu04BWyJ7+NLeA@mail.gmail.com>
On 28.06.2022 09:35, Clément Chigot via Binutils wrote:
> This patch ensures that the gcc binary called by windres is quoted if
> needed. Otherwise, errors can occur if the gcc is under a folder having
> a name containing a space (eg "Program Files").
>
> binutils/
> * resrc.c (DEFAULT_PREPROCESSOR): Split into...
> (DEFAULT_PREPROCESSOR_CMD): that...
> (DEFAULT_PREPROCESSOR_ARGS): and that.
> (look_for_default): Add quotes around the command if needed.
> (read_rc_file): Adapt to new defines.
Commenting is a little difficult without you providing the patch (also)
inline: Shouldn't you also (optionally) quote the pre-processor string
if that came into read_rc_file() as non-NULL? Everything else looks
okay to me.
Jan
next prev parent reply other threads:[~2022-06-28 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 7:35 Clément Chigot
2022-06-28 9:00 ` Jan Beulich [this message]
2022-06-28 9:37 ` Clément Chigot
2022-06-28 10:16 ` Jan Beulich
2022-06-28 11:57 ` Clément Chigot
2022-06-28 12:26 ` Clément Chigot
2022-06-28 13:51 ` Jan Beulich
2022-06-28 14:18 ` Clément Chigot
2022-06-28 14:40 ` Jan Beulich
2022-06-28 14:55 ` Clément Chigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b117237e-f665-2da8-64f4-53018e2a09b1@suse.com \
--to=jbeulich@suse.com \
--cc=binutils@sourceware.org \
--cc=chigot@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).