From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by sourceware.org (Postfix) with ESMTPS id 74F113858D1E for ; Tue, 4 Oct 2022 07:43:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74F113858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxvDvOanomain7+746q6CGCY/pWuE8NMKhKfGMwyKcHvraPIjiCGjv90rndC+9ZmspgZIO0bRQhYFlMjO2ueZZVnfnxQ0iib2DlXUY3aoDUpporiFDRne9YHOuQPvSDMoKWezjtgKBsNskeJ8ztafHaQRTojQg2rpD8XNi4ukC7TV7rQ7Ciw2UoNH0DXsrdyO0hON9M/QaBtC8X4l11KuHN5KSAw2RMMqV7ZRZrjqlq4HkxBal8Vwgl3SNVsFUj1xfM4dOwrwjpt/BabYEgcTnJMATwz89NopTEhOiR9Vf0rTvpfmH5dIY3eSbNsywONUB4jzdIyt9Nck+pCRx1w7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I7lcI0M2u4KZ5xkzDAaGQCwJr4SiCphY9JDo4YHYqK0=; b=KWgN96g2yjq0m9VNJ2FqpOFHBT94mGS3MxSL5Ze+3iHcn2mH3GXp/4LTp71haBy2rlcEtQKTfgwHkH2nUi8J60c1rdI/MgnUwrvzq78hsvHTYW4ZE6/OFhMiluHz57snGUulp6cEd+9mudMkooSPapoQzheNACBROSuyof6U84E7TLQGlJSLoAcRiGurtjh4ecE/Bi6xP5g81BhlxtRWmBm+M7uePBBQhQdCrh9UzfHZGMR4EfsXarSy+h51l7XpOnb1YNKn5vCpVysfT9qVeEUW/TA2Mw6RcvAGqq6sYDK7uzIzbasHa0Gu+PXIc27WZpfG3IKTsaYYaAxogY/ktA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I7lcI0M2u4KZ5xkzDAaGQCwJr4SiCphY9JDo4YHYqK0=; b=qMfPgXoF+V7fIIXO8Spg70zk9o6xbgrCObOZpYd4M9Tsx9xjnITXwQJPKOdD8+/b3fO7KolSmRYT0JKszf7MYWvYx1OpMoDowTkMbPoUDeIwsvvy+DQHxIftd3oDT61HOLmPU8avPHA1JyjHCEle/uOdnHCIYWDunlZ8q82DEbpaZFN2OxBeeJrssWk4pM+qQ0pLVbZkGWi4rXZyNHA7vDRj3se4Top23WRteLY8Elu/dzgbZc1CxNcdA06I6P3jR8aVWGceYZrMK/VBYBfn2SgmSn5bRaop9cD40VS1qQdetHfrtX2Zpm3a/M6m7kXQyUnprLoQXv/7mU65DjmY/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6892.eurprd04.prod.outlook.com (2603:10a6:10:113::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.31; Tue, 4 Oct 2022 07:43:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5676.031; Tue, 4 Oct 2022 07:43:06 +0000 Message-ID: Date: Tue, 4 Oct 2022 09:43:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V2] Ignore DWARF debug information for -gsplit-dwarf with dwarf-5. Content-Language: en-US To: "Potharla, Rupesh" Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Kumar N, Bhuvanendra" , "Potharla, Rupesh via Binutils" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0019.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6892:EE_ X-MS-Office365-Filtering-Correlation-Id: 25fdc4b6-656b-4a2a-5399-08daa5dc12f1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DWhjMOkFzMkayhToHznzWOxYAKBeErmt6eWagAD+f4JIww0Ii6GGmbLQMni7sDx0GoWf4JVLFj+xw/1cZ5pHjWbx0YaAhm+DVVukygNOYwtkn0hp95dSAOlhC449Xc64folb3U9BPFXr+Z/afVPuKAYwoHccQa4M6Gs73FXHmryFc/kBlh1tqyCTUrCY2rFh2qWwtGgUE8MfnJY20Xh9M/DRtaz5ZyUIq4Ynnk/oUXnQUW70j0mG8IINoqmmhyy5t/lvXsCphGVkZ662y1hxv9YnbLSLEZ1thlvgKT/r649iRzMjV8bCbFPgbyYa9DMqKwAxKvaOdV5jrHu/fY2mc5scAKLM7Xk6kvrrFcpYfTCvcNRuf2Vab7FO7mROe1BOTf82kR1olkwQJhMp2uoXyyxM8G80OKZ/36MB7MJ4wBjh6gkD5Hjwc7YanKKKXBQNGYgORO1WGep9tMDVXdkk/58iFT+1nYa0II3tZByO8xGFKuz1XXkDZd+bcDA0pQ+fYJf/5ZLT7qqJ3YK9Bqi5rraO/Slj/AXGpnxVB9y7b1owOGJnREMy6okR56cJeG0DFLrYsMd58wYGR9fSEG4MJc4vRaPGK3djGU9XTYvfXuK/iqbznq/LTHfGBx1a0A0fpDSxcLMjAvUmTo9ydgrBLZCvIqf7H00JTdTVuLfaMB5RYDv2/Y62B3vB22aDibNbWf0D8apgjBdLcm9mBBoB6rTC8Vq3ZKpc7Xe41yoi/RwH3EXDP0fM1LpHxfdcMBAU3iHL2SZgb+/JtcSgnYi5WR+FA3ljO5F6RRlotwE5nL0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(396003)(346002)(366004)(39860400002)(136003)(451199015)(6486002)(478600001)(31686004)(6512007)(36756003)(316002)(186003)(2616005)(8936002)(2906002)(5660300002)(4326008)(8676002)(66476007)(66556008)(66946007)(53546011)(54906003)(6916009)(26005)(6506007)(83380400001)(38100700002)(86362001)(31696002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFdGUVZpNWoycmlBaDZWWU9QVFp1cUFML09TYm5QRFVFd1RTWDFFZ3BoeTFG?= =?utf-8?B?TmxTbXRmek9JeFBVVURBd1BZUTFNL0c1dDM5YjJhd20raEVldXhUTEI0ZVpz?= =?utf-8?B?L2trUU1SSmN5a3ZoejBWbjZhcE9QRHpyYWhKOUNtNGU2RlQ3Vmhhcm9lTUVH?= =?utf-8?B?V0xKcE14VGFkalJDTXRNbDBMMEM3R3pTMjNvdGxONFRUUUJoa2dOclh6cFdZ?= =?utf-8?B?ZHpxWTMzby9tdkowQkZpUUkyeU1tTy9qSDYyTmdlbmFiSWFwdVlpemZsajVy?= =?utf-8?B?UEdta2lFbG1vTmF6cHhrLzJTWVJDdXFkN1BHdGdVaHVpNXlmT1NzakZFM2dG?= =?utf-8?B?MGo0bXFmMzQ5dEIrMnF0aTk4L2g4VmJMeG85RHlJMzlDQVowbVBaNDBCR0tw?= =?utf-8?B?Z2c0Q3BkOWMzc1ZxYnc4WWxyZmtrSkt3bldQODVqejJ0YnpEdVp6YldMR0hU?= =?utf-8?B?bm80V2ErRng1MW1IdEtrV0lKVGMrd2licW9MZTdKbEp6dldIQTZ5ZkM4Y216?= =?utf-8?B?b2pQZC9xL2RNdlRaMGg5NC8wQVVWQkY3SVMyc1JwazdmOWdKeFZOY0pLenFJ?= =?utf-8?B?dHhCbExsc3JicVZrUU5QNWF4ZDRwNjJSTzNFejdXMGFaNXIvVGdVL1A4djNR?= =?utf-8?B?TENjNkczMThKUTdsYXlKMWVDakdLREVGemJaN0JnUjJhclVyTGxZS2d4Qm13?= =?utf-8?B?bUgrTHEwQ1FxSndEOEJVL0VXYjZuS3NwN2ROeUQ5QkxqdGpsVXhrUndRcVNp?= =?utf-8?B?ODdQanJpeDlZK0hFNmhQTTM5bGhZc3R1M0ozVWhSWmhuOUFpY2pVNEJhZnVz?= =?utf-8?B?VE5JTW8yclVpS0pnNFd3MzBVWXRCSjJPSTFPRWYxUkFLaUdWcnFta2NFTlpP?= =?utf-8?B?M000ZWo0K1J0Wno5b2NRSFhyWGdtMkVpY29PV2VLUStEYTNwcHlSWmFCMEdx?= =?utf-8?B?c1FzZjlpclN5dk1PdTV6WGc2bzRoS1Z6NVZ1ak9XZ08vcVpJWXVvZGp5Z2Mx?= =?utf-8?B?b1hkT3dab1lQNXAveDYxZmUxZVVyek5BQjJOaTlLTzBoMEJ6STAwOVZnUVAy?= =?utf-8?B?VnhVaUpTb1VrOVhDSE9ra2I2dllOSy8yQm8xWVVYdThUckFLWHYvZjFjUmtB?= =?utf-8?B?Z0ZJNm9QWnREcXBKY3p3MFpMcjBaUVJqeGUyY3RJdkJpVFZhZXZNWUhVQURN?= =?utf-8?B?VXErRXQyaEROL1kzamZlZkE0MFR4cFFhMnpCb3FMOExxWktIM1R2a2V1Smxl?= =?utf-8?B?WXNaS1lxb2RQVTl0TC9Sc1BqeFJud3lDUFlySHVZNWdvTUo1cE5GQW9GTnVU?= =?utf-8?B?WTlXMWhNaGQvTldScmlEb1Nsa1dRRS9JN0sySXdFZlZtNkZwZis5bXF6eC9R?= =?utf-8?B?djRMTDNrR1kyc0s1YWJMZk8yZkQzMG5UbHBGUGJaaXpvWWdHbU9xbzZjdlBl?= =?utf-8?B?eFBtN3ZjYUM5QVNNMExNUzc1N2FQRzJ1eG5oZXFvbjE1eXAxTW5DeUpCZHN2?= =?utf-8?B?UXh5Z0lYTSsyU1lIM3FBUXN6RXY2RjNCWjFGRFd6Tmx4OGpWalZRK2ZlR3hn?= =?utf-8?B?UDRRRXN6cWxNcUxTVUNoaSt6eEhtOVM4ZGd0M3V5T0pxMzZlWXh6MDdJN1Fr?= =?utf-8?B?NGlvMlJhOUhiclIyT0JJZTdYNWZkSlZuZWpwZWtGWEh4b3IxcGNrdHJJRlVm?= =?utf-8?B?QWh2ZTZ6dVVSSnE5SWl6OTQvcDdwVHZybHBMdkd6dEpVaW9wVmNBZWFWZUF4?= =?utf-8?B?enFjKzZ3MUpyZGptL2ZveitHRFhmQ2ttTThSb3lTWk1sTHVlbFVaZmlyVGNr?= =?utf-8?B?V3pMQmJVNERxSHkrOTJtdzNSRnBnMnZPM2ZZSG1FRXhYSm9XOFRxRXVDelZG?= =?utf-8?B?R0hCTXR4MzJHTVd0UkoxTVJJeno2RzlReWY2OVloclR6MlJvYjZkWGk4OVFx?= =?utf-8?B?VTNqcDl4eGdhbVhoMEF6cmZ2UGV5blpNbVptK1dQVFM5UjZObldxQ2JkWEYy?= =?utf-8?B?Ukd1Q0MzbnFyOHdLSHZYeDc3ZldxMXZ1dGFUU1dwNkVpMUlDUW14U0l4dWN1?= =?utf-8?B?MjJEcVA0TjM5aFZwd1BLdEhmUUZtOE5pT2loS3lXbWNsVTlXUGErQ3lBbFZ3?= =?utf-8?Q?ErfO19NsCdv2BrVKoE9IFG9iw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25fdc4b6-656b-4a2a-5399-08daa5dc12f1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2022 07:43:06.5227 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TSkapfWQFUCF2mYyUBjo/xpHLu9QHhA1zUX7Rt9Q7B4vRI6mzp/TruXXoX7/2gczF1IbEivdxzFLcR5lZOx4wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6892 X-Spam-Status: No, score=-3037.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30.09.2022 13:41, Potharla, Rupesh via Binutils wrote: > [AMD Official Use Only - General] > > Hi, > > Can you review the code changes and send in your comments/suggestions? > > Patch Inline: > ----------------- Thanks, committed. I'd appreciate though if you could submit patches just as patches, i.e. not including any further data (like everything above). That simplifies applying. Jan > Skip dwo_id for split dwarf. > * dwarf2.c (parse_comp_unit): Skip DWO_id for DW_UT_skeleton. > --- > bfd/dwarf2.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/bfd/dwarf2.c b/bfd/dwarf2.c > index 4a6a1e40185..364cc9a6480 100644 > --- a/bfd/dwarf2.c > +++ b/bfd/dwarf2.c > @@ -4411,13 +4411,23 @@ parse_comp_unit (struct dwarf2_debug *stash, > if (version < 5) > addr_size = read_1_byte (abfd, &info_ptr, end_ptr); > > - if (unit_type == DW_UT_type) > + switch (unit_type) > { > + case DW_UT_type: > /* Skip type signature. */ > info_ptr += 8; > > /* Skip type offset. */ > info_ptr += offset_size; > + break; > + > + case DW_UT_skeleton: > + /* Skip DWO_id field. */ > + info_ptr += 8; > + break; > + > + default: > + break; > } > > if (addr_size > sizeof (bfd_vma)) > -- > 2.25.1 > > Regards, > Rupesh P >