From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2075.outbound.protection.outlook.com [40.107.8.75]) by sourceware.org (Postfix) with ESMTPS id 8C0FF3857835 for ; Fri, 26 May 2023 07:30:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8C0FF3857835 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MpKycouTpCtSRKSDXB9dZHwxUZzu8jnNKzlHFhxNZQ5Y07sspZoZsxAbPYCNfa05IqVyliVqbkHFtvvyfFtWEEzJhJvfFs2xApKk7omE5SQJw10c62xri1laKe2ebjEQgzBLESEiQemM5GH8Z4PZpE+cfckt7dirQHvcDvEoubSq4JdNY+MkuJCn+RX6ukRPX7DzVv1B2qwORjQBT8E4XzIq57Cn+Cn/T2Hrh0V1AOGYjzEGMPudO5ez3NOOrqpJCSUbBxtJRhs86LrAflnK6ncl3OwbAXCOTceEBIQZakEl0uHDpsz0iW1Juv/J6MNMW/OUCedJqPks4d5CKglqSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rx4xieVf2Y5ozPtA/I4cPg3qfTCyH2auzhzE2pykTGg=; b=Hc+zCSNlRzfCrJEjvrbxd3M30Fkidx8yxIq+rFzaeGkvceKyph67QdsEIFKe06OrG1b5+sz8E6xD7rJtB0qGWcDpe+HDlpzQibQgMYuZo2SBvVWu+xZvxQtiRmwXXyV26sL126P1UW7rn2LYQRcOdmF6fBmCy3oe70CAuSHJWXY7X1qFNGGiKNLCFiZx0+0m/vlARsO9H5S0bo7S1qCsv8mFtDIbdx+R5kPQKbnkmFey8zXjEqaaopBiKiu9Sm5H/6FIQwcZTvjeQ3Nn7vMe/kQrULjoGnh5jDHHgRRDUB0/pShGVUcUS0x5/AagG8hb/vj1A6s34ZgtuBSEmqz1aQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rx4xieVf2Y5ozPtA/I4cPg3qfTCyH2auzhzE2pykTGg=; b=3636zPoBKct1bh9KbVrL3JRUWEUfsHrpjfA63TkKwVAfjJzP5DETmX/bO13xuVMWXtjgP7tMjsrGhkn0VOk9f9MxsMIo9s4sXqYgPoBBnYaT65oxYdYQQX5B0Q7yxU+m7+8Mz1vYbgf5efClAYz9y7JPPhRbn5oPF+MKhvvUBHQ5bL35ckWs5HxkbuBOEvAVt+hQx8TiWh775dijcn6bJQi/p9fCSQZNZ1p7x9l7YGJfMuLJ1iZgTGx4MrgG+8ANZCBB88SO7dBaLrL5St+XYzmnc8FcdOFxNo+uWpq2Dzyvk+SsDiYALaRGRRPOncynjva476kNr30V2o7gidIJ7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7406.eurprd04.prod.outlook.com (2603:10a6:800:1ae::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.16; Fri, 26 May 2023 07:30:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6433.016; Fri, 26 May 2023 07:30:23 +0000 Message-ID: Date: Fri, 26 May 2023 09:30:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [COMMITTED] libsframe: revisit sframe_find_fre API Content-Language: en-US To: Indu Bhagat References: <20230526070132.4185600-1-indu.bhagat@oracle.com> <20230526070132.4185600-3-indu.bhagat@oracle.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230526070132.4185600-3-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|VE1PR04MB7406:EE_ X-MS-Office365-Filtering-Correlation-Id: 92d310ff-c5ed-44f4-7a65-08db5dbb114b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dGKDe+gnf27TX6Qtj1RrwQD3kZvZ72YPvjQUI52Dn+UkS0nYF8gNk7GkGaZ65kpF+CMJs/brMlpZVlP6UwY6L+nV2JBSWNHGFAiQWrV6WhhtAyaMpeaoDYnPsJJ4BUMEgqiTMR8udU58ngThd0Y2+yETFh4vU55ZzakxhXezbCfWAehibJqFdIjiRt37P3c271lI92zTnvslLRT0fqc2r5+50LzRXX88CbJYP+3tANosaccXnf95WzKN4+pEqP374TWd0T1fjDa+iKOmFBApZtJs2m/rH+4kdsqy4hzauZlFkoDMS3CUoz3wo4BNJyeZueOwY1IMs28dL3IGsQYOoARnv5elfgDMpyscESPqwzZDwaLAFX0Oe5RzfQRNOVzUtv9L41VH7y2HkDcW5at3A9lpELngI0lz2/kDIxZYT0ttcY6BEOGo9RwpsLx3UJIg65nxkkZhu92V98lSKr7PIU5V96y4CUrXHj6ZHKwC9czTRYy3gZlqUrS9SvjdU2rO/MoaeKb7lay0sW42dPoZPuDCeVUTP23qxI8QI6JhxDQ+j0+Eh6c7g0S0vX05JVZZ49dvLgEQv6AFVW5NtzyOHq0r5sWc6PTYENo6xtAk3ijbBTR+DoXLgOhPNCb+xGxfjQQ1oTO9tk5W2UoClbdPLg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199021)(31686004)(66946007)(66556008)(66476007)(478600001)(6916009)(4326008)(316002)(31696002)(86362001)(36756003)(26005)(2616005)(186003)(53546011)(6512007)(6506007)(83380400001)(41300700001)(8676002)(8936002)(2906002)(5660300002)(6486002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUJiWFBMc3l4ekQxaGtuZGpHSFhXUHVVZm5sUVhwTEZiTzlSblJVWDcxUjVk?= =?utf-8?B?MERldHhHNGE5NzF3QmxRa1ZNN2pkVWdHbkNmenFOTFprL0w0MGVFTkJMQ0d2?= =?utf-8?B?UUhGcDJVTmpTRzhhNGladEd0ZEVXS0loTGhqTjQycmYyN0RGbmxydXRNaTdG?= =?utf-8?B?THpOaGhlZm9rbzhyYXZMWk5hT1NmZ0ZDT2JRVVQzNkpJSVdOdS90bm1tVDdl?= =?utf-8?B?eUI3aWgvUFcrZjBrYTF2elBic0Q1T3hDaTEvVWdkNFNXbm1NNitkSTBWdWpV?= =?utf-8?B?NG1vMkNtV1NaREozdFRQZVpFQitCYkFNdnQwSXZISzFVQ092N2orRDMybjAz?= =?utf-8?B?RDkxSlhIbGNQdDlOS0tRRnp1NDJMWVpRTTl0ZTlhN3l6bzZ2RW5MZnpORHFB?= =?utf-8?B?ZjlVbjMxUktuVWR2eTF1b3RIQTc1aDB4NWNLdmFDQ2NEWW5HSGpMQys2Wjdv?= =?utf-8?B?bDk2bFY1WjJaaTRuWWJ3U0N1WmJ3YUoyT0pWUU0vZHRRYitUaVZtV0E3N1Jt?= =?utf-8?B?eEVRSFdVSlRqSnhNdVV0TE9pRk5ESngrZ2VDL3ZkRjIvTmd6TjhNTll6ZGoy?= =?utf-8?B?R1lPVWJkUHdFTTBuWVNGcDRRQjU5dHNzMlRLVVZKUjN2SXExVlIvbGZudjlR?= =?utf-8?B?NXd0Y2Z1WnZEOURNYVRXaDJBbW1yZVlQM1JCUnZxc28rNnJGTG1DRWcvcldG?= =?utf-8?B?UzJ6MS9KbnFDYnNrRTV0SnNBV3VaUXdTS3ZtOFVWUkI2RXpscklEYjVLdlZT?= =?utf-8?B?NTJGYVpIWU1CK0tsWlNhRmUxQzcrQmt3WlpYSGNqdkJVYm5kam12OGFhTGtt?= =?utf-8?B?cDZOS2xYQWdZb0FRNGVHU1NZVzhqbTQ1YnMybk5sRG9rVTBFQ1l2NjhPbWZL?= =?utf-8?B?Y0FOM2JRNUhVUmdHQkFOOUdic3crZ1NIcU1jSVI5ekJ5Z3lZYzNiM0xpZFlC?= =?utf-8?B?N0VReHppTFM5S3pWRU5ucnBlRkU0UHNMb3J3NTV0UUNYMHY5ay9VTldIQ2dD?= =?utf-8?B?Wm41S1kzd1dvRGc0M0cwTHUrUytnYlA2bHk4Tzd4eXlhOWlVYTZ6enZPSExq?= =?utf-8?B?VExuci8xdG44Ym1Ub21XV3Nyd2I2eFBPeUtvcXhXWm9ta1hnL2ozTUx4dXZv?= =?utf-8?B?VllicDNqcjE3WVpHUUE3TjY2S1JUMGxwWmMrOGR5Vksyck5nOTJYZFYrR2s2?= =?utf-8?B?ejIxN0FIOXpRYlVrbkljb2JacDc3ekphM2pQaVZRUHRXemhJcUdQa2NBQS8v?= =?utf-8?B?KzJDUUhVN0dJR3RhTERhZjJUVUlzTTdmREl3blhDMkJPL0FScGRNMzE3Si9Y?= =?utf-8?B?RkZVajNuU1JKalB2Y3BXVXFKa1NPZ3RYbDVJcUd5d3N5SGc3S3I3WGkvT1NM?= =?utf-8?B?cTBQeUNiOHBYbEc3M3RHdHRqNWdDTlRKbUNKc2RPQmo1Q2d0NFJTRC9jbU51?= =?utf-8?B?TnYyUitLUk9BOFBQa29qYml3Rm8rekRSb1N5Rm5STE5lSlpSR1lOL3Z4Zmdl?= =?utf-8?B?dTVXcmk1N1hyU2xkeEQ3S1FoZFBSUnVBc0xJUVlvSERqekM4eHVJTXlWTG1F?= =?utf-8?B?NktDR1RoYlUrSmNKa3dTVk1XSW4yWnNRYVVZNUF2d0ZpcE52Z1psQ29icTFv?= =?utf-8?B?ZEo2MzJ1ZVpaMWhTWkxDNS9kQlFrMVQrT0ZUOU1heVU1OTZJSlA0QzJXU0wr?= =?utf-8?B?dkV6MDNOWUg3Y0hsSHhaTFFwRTZ1VnhTU050L0tYamtRSEhhTVhNaWVvTVVQ?= =?utf-8?B?cXBGUVk2RDhBN2lkT1owcG14dmFkdUNORVYrVVV6cncyT1BzOWxZZWZNSGpn?= =?utf-8?B?L0tFUXg4c3dDbkt4WllQS3lUVUUwMEFTWCtxcFJTbTR4QWUrNmdUNnV0ZTdo?= =?utf-8?B?UDhoWVFzai82L1ZHRTAzWXRuNGtGZXc3bzFXL1NLaVRHR0VSaW13RFZELzRW?= =?utf-8?B?TW9DdXkrTFBGOTNMMTV0VzlqRy91UnpCR0hLUWxvd3RhMlRXcFExYmRUMFJH?= =?utf-8?B?NXp0Q2dJTU9CR3JGTnpLTEtraVZKd1JzOCtRZTZWWGxKeExjRXE2WG0wSzI3?= =?utf-8?B?WCsyOTE5OWpxTUs2TlRKMXpNT2R0WXdDQ0lzRW41S0VFRndlSm5WY1NSTndK?= =?utf-8?Q?0g7pZrDNxvcRTZ8te+5fEq341?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92d310ff-c5ed-44f4-7a65-08db5dbb114b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 May 2023 07:30:23.5375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: no6M7yEqZ/tuWVtqQzyWtO8weGE4PnncuoMM2hlPcFMVmg2KIQRDeRSytLrUqe4yaR8aocPs0raO7DcJYcVS6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7406 X-Spam-Status: No, score=-3027.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 26.05.2023 09:01, Indu Bhagat via Binutils wrote: > @@ -1022,40 +1049,28 @@ sframe_find_fre (sframe_decoder_ctx *ctx, int32_t pc, > bitmask = 0xff; > > fres = ctx->sfd_fres + fdep->sfde_func_start_fre_off; > + func_start_addr = fdep->sfde_func_start_address; > + > for (i = 0; i < fdep->sfde_func_num_fres; i++) > { > - err = sframe_decode_fre (fres, &next_fre, fre_type, &esz); > - start_address = next_fre.fre_start_addr; > + err = sframe_decode_fre (fres, &cur_fre, fre_type, &size); > + if (err) > + return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); > > - if (((fdep->sfde_func_start_address > - + (int32_t) start_address) & bitmask) <= (pc & bitmask)) > + start_ip = func_start_addr + cur_fre.fre_start_addr; > + end_ip_offset = sframe_fre_get_end_ip_offset (fdep, i, fres + size); > + end_ip = func_start_addr + end_ip_offset; > + > + if ((start_ip & bitmask) > (pc & bitmask)) > + return sframe_set_errno (&err, SFRAME_ERR_FRE_INVAL); > + > + if (((start_ip & bitmask) <= (pc & bitmask)) > + && (end_ip & bitmask) >= (pc & bitmask)) > { > - sframe_frame_row_entry_copy (&cur_fre, &next_fre); > - > - /* Get the next FRE in sequence. */ > - if (i < fdep->sfde_func_num_fres - 1) > - { > - sp += esz; The buildbot failure just reported was found on the commit prior to this one, which removed the declaration of sp. Please try to make sure that every patch builds (and works) okay individually. Jan