From: Nick Clifton <nickc@redhat.com>
To: Pip Cet <pipcet@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] [WebAssembly] Skeleton support
Date: Mon, 27 Mar 2017 12:44:00 -0000 [thread overview]
Message-ID: <b2b48495-27e8-e2b6-d3db-2036b418cd8e@redhat.com> (raw)
In-Reply-To: <CAOqdjBdk9E13b=k0nO99eMZWoaLiCap8ph36jCy0RyjHxCAdzg@mail.gmail.com>
Hi Pip,
> 2017-03-23 Pip Cet <pipcet@gmail.com>
>
> * wasm-module.c: New file to support WebAssembly modules.
> * wasm-module.h: New file to support WebAssembly modules.
> * doc/webassembly.texi: Start documenting wasm-module.c.
> * config.bfd: Add wasm_vec.
> * targets.c: Likewise.
> * configure.ac: Likewise.
> * Makefile.am: Add entries for wasm-module.c.
Approved and applied.
One comment I would make is that we prefer sentences inside
comments to have two spaces after the full stop. This helps
emacs's sentence parsing code. But this was not sufficiently
important to hold up approving the patch.
Cheers
Nick
next prev parent reply other threads:[~2017-03-27 12:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 23:21 Pip Cet
2017-03-22 12:55 ` Nick Clifton
2017-03-22 16:12 ` Pip Cet
2017-03-23 2:56 ` Pip Cet
2017-03-23 14:51 ` Pip Cet
2017-03-27 12:44 ` Nick Clifton [this message]
2017-03-27 10:43 ` Nick Clifton
2017-03-27 10:22 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2b48495-27e8-e2b6-d3db-2036b418cd8e@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).