From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BBD673858429 for ; Fri, 11 Feb 2022 12:47:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BBD673858429 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-151-iBzDHg6hPhiRd8ZszHlgPA-1; Fri, 11 Feb 2022 07:47:20 -0500 X-MC-Unique: iBzDHg6hPhiRd8ZszHlgPA-1 Received: by mail-wm1-f72.google.com with SMTP id r8-20020a7bc088000000b0037bbf779d26so2460762wmh.7 for ; Fri, 11 Feb 2022 04:47:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=gLjvtyb9eJ90bwJzMOHVmEYLcdclj6n7dpxJPTqEWwg=; b=yPd5/tdHW6F7wS8B3OzdMV0gSDH8+IoUGzCqFatxAf1TCWs0ZdaVNszrU0hf76kHYN OEcNpJim64o8cL+/n00w9SV3OIRIRdSBd7QVXmM0Q4tDr3SdjaPuW7nL9SFihDVysw7s FYP1e5MS4uJWipqpZN8HOws/DHAUTYcRUQay2taLZBrMSqGmSrzybjoLjfF+6mhWudYX D1dnB9Jzx6w0fSdpKTcVho9UmoTYptljYnr6WtUuvrRXNHCdbJnhfJF51RIieXUyhEnq p3nC3cTa9qGVORm1MqHEW08jHBSAjOLdXxd2gOzfu7f2FlNkZQHa7fZL+ITFr+VuUE21 jISA== X-Gm-Message-State: AOAM5300DiIFf61ARLgrGndpVbh73pUO99DzLhSIbQ3fQzceJcatFLna Ccneog4qzJ8Os7E1DkOHnQxeqZ5hkXI4TuRtgmBn+PabKe6o/x9Yr/IrlPWC0nNjrZoI6xZhwFc ipFcAradoh0AP+NM8zQ== X-Received: by 2002:adf:e708:: with SMTP id c8mr1255057wrm.653.1644583638463; Fri, 11 Feb 2022 04:47:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5pP1ZWTGmdkoJVFptGeg3O+M6guP1BlPdOdkliJpNFNW50Qq5HwGMHC+9DTNJiyDzpolKhw== X-Received: by 2002:adf:e708:: with SMTP id c8mr1255047wrm.653.1644583638318; Fri, 11 Feb 2022 04:47:18 -0800 (PST) Received: from [192.168.1.6] (adsl-2-solo-173-39.claranet.co.uk. [80.168.173.39]) by smtp.gmail.com with ESMTPSA id z10sm3717361wmi.31.2022.02.11.04.47.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 04:47:17 -0800 (PST) Message-ID: Date: Fri, 11 Feb 2022 12:47:17 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] bfd: Remove return with expression in void function To: Michael Forney , binutils@sourceware.org References: <20220210231012.6562-1-mforney@mforney.org> From: Nick Clifton In-Reply-To: <20220210231012.6562-1-mforney@mforney.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 12:47:22 -0000 Hi Michael, > 2022-02-10 Michael Forney > > * bfd.c (bfd_set_gp_value): Remove return with expression > in void function. Approved and applied. I am actually surprised that this was not reported by the compiler during normal builds. Cheers Nick