From: Simon Marchi <simon.marchi@polymtl.ca>
To: Fangrui Song <maskray@google.com>, Nick Clifton <nickc@redhat.com>
Cc: Alan Modra <amodra@gmail.com>, Jan Beulich <jbeulich@suse.com>,
binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections
Date: Fri, 23 Sep 2022 14:57:53 -0400 [thread overview]
Message-ID: <b409b8b9-bf78-d23a-3048-accd4ebf0c7a@polymtl.ca> (raw)
In-Reply-To: <20220923182038.ilg6lh235f6zzdmr@google.com>
On 2022-09-23 14:20, Fangrui Song wrote:
> On 2022-09-23, Simon Marchi wrote:
>>
>>
>> On 2022-09-23 11:45, Nick Clifton wrote:
>>> Hi Fangrui,
>>>
>>>> PR29397 PR29563: The new configure option --with-zstd defaults to auto.
>>>> If pkgconfig/libzstd.pc is found, define HAVE_ZSTD and support zstd
>>>> compressed debug sections for most tools.
>
> Hi Simon and Nick,
>
> I have checked that `make all-gdb` works in a --enable-gdb --without-debuginfod build.
>
> I then inspected the 2020 commits adding AC_DEBUGINFOD to
> gdb/configure.ac and binutils/configure.ac. They come with no
> PKG_PROG_PKG_CONFIG and config/debuginfod.m4 does not have
> PKG_PROG_PKG_CONFIG, but they still work. So I think AC_ZSTD doesn't
> need PKG_PROG_PKG_CONFIG, either. Though I have no insight why it
> behaves that way:)
Ok, I am a bit confused. Based on my comprehension, since the first
call to PKG_CHECK_MODULES may not happen do to a condition:
if test "x$with_debuginfod" != xno; then
PKG_CHECK_MODULES([DEBUGINFOD], [libdebuginfod >= 0.179],
...
fi
... the probing for pkg-config should not happen if --without-debuginfod
is used. But in gdb/configure, I see that the probing for pkg-config
actually appears outside the condition.
Anyway, good if it works.
> +diff --git a/gdb/NEWS b/gdb/NEWS
> +index 9619842bc03..1457c99ff04 100644
> +--- a/gdb/NEWS
> ++++ b/gdb/NEWS
> +@@ -57,6 +57,8 @@
> + + * The Windows native target now supports target async.
> + ++* gdb now supports zstd compressed debug sections (ELFCOMPRESS_ZSTD) for ELF.
> ++
I'm not sure I understand the diff above, but I think it's missing an
empty line between the previous bullet and the new bullet. Otherwise,
that is OK for GDB.
Simon
next prev parent reply other threads:[~2022-09-23 18:58 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 4:08 Fangrui Song
2022-09-23 14:32 ` Simon Marchi
2022-09-26 5:12 ` Alan Modra
2022-09-26 7:20 ` Fangrui Song
2022-09-26 13:30 ` Alan Modra
2022-09-26 14:08 ` Simon Marchi
2022-09-27 0:33 ` Alan Modra
2022-09-23 15:45 ` Nick Clifton
2022-09-23 15:58 ` Simon Marchi
2022-09-23 18:20 ` Fangrui Song
2022-09-23 18:57 ` Simon Marchi [this message]
2022-09-23 20:34 ` Fangrui Song
2022-09-24 5:43 ` Eli Zaretskii
2022-09-24 6:53 ` Enze Li
2022-09-24 7:13 ` Fangrui Song
2022-09-27 18:06 ` Tom Tromey
2022-09-27 18:08 ` Tom Tromey
2022-09-27 18:53 ` Fangrui Song
2022-09-29 11:43 ` Martin Liška
2022-09-29 20:17 ` Fangrui Song
2022-09-30 9:48 ` [PATCH][RFC] add --enable-zstd-compressed-debug-sections configure option Martin Liška
2022-09-30 11:25 ` Pedro Alves
2022-09-30 12:42 ` Martin Liška
2022-10-01 7:31 ` Fangrui Song
2022-10-03 7:49 ` Martin Liška
2022-10-03 7:50 ` [PATCH 1/2] refactor usage of compressed_debug_section_type Martin Liška
2022-10-11 7:14 ` Martin Liška
2022-10-11 12:06 ` Nick Clifton
2022-10-11 13:27 ` Martin Liška
2022-10-03 7:50 ` [PATCH 2/2] add --enable-default-compressed-debug-sections-algorithm configure option Martin Liška
2022-10-11 7:14 ` Martin Liška
2022-10-11 12:08 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b409b8b9-bf78-d23a-3048-accd4ebf0c7a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=maskray@google.com \
--cc=nickc@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).