From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 0E0643857C6F; Fri, 23 Sep 2022 18:58:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0E0643857C6F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 28NIvsUR005794 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Sep 2022 14:57:59 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 28NIvsUR005794 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1663959480; bh=jsxQuyzzWUNYHLdbOxLHrrOtrtrZWPm//mKdC5OuhLo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XbLltDXehZE8OnpZpcZu3ZkQNj1iNBzFWMWSw6htyIxfX4MX3vkBuyjy0aTy+71tX 9LeN7Xw7sl2Gr6NoTXu2w8kYKkr4yr3bkxLZqn/EjaiwUG88/dq/tmfTDA41ZpPPWr WaiJyvF3IFKXXPzmlD2eRnylJIvQ+2zzOPBwvaME= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 10C471E07B; Fri, 23 Sep 2022 14:57:54 -0400 (EDT) Message-ID: Date: Fri, 23 Sep 2022 14:57:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] binutils, gdb: support zstd compressed debug sections Content-Language: en-US To: Fangrui Song , Nick Clifton Cc: Alan Modra , Jan Beulich , binutils@sourceware.org, gdb-patches@sourceware.org References: <20220923040837.550160-1-maskray@google.com> <20220923182038.ilg6lh235f6zzdmr@google.com> From: Simon Marchi In-Reply-To: <20220923182038.ilg6lh235f6zzdmr@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 23 Sep 2022 18:57:54 +0000 X-Spam-Status: No, score=-3038.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-09-23 14:20, Fangrui Song wrote: > On 2022-09-23, Simon Marchi wrote: >> >> >> On 2022-09-23 11:45, Nick Clifton wrote: >>> Hi Fangrui, >>> >>>> PR29397 PR29563: The new configure option --with-zstd defaults to auto. >>>> If pkgconfig/libzstd.pc is found, define HAVE_ZSTD and support zstd >>>> compressed debug sections for most tools. > > Hi Simon and Nick, > > I have checked that `make all-gdb` works in a --enable-gdb --without-debuginfod build. > > I then inspected the 2020 commits adding AC_DEBUGINFOD to > gdb/configure.ac and binutils/configure.ac. They come with no > PKG_PROG_PKG_CONFIG and config/debuginfod.m4 does not have > PKG_PROG_PKG_CONFIG, but they still work.  So I think AC_ZSTD doesn't > need PKG_PROG_PKG_CONFIG, either. Though I have no insight why it > behaves that way:) Ok, I am a bit confused. Based on my comprehension, since the first call to PKG_CHECK_MODULES may not happen do to a condition: if test "x$with_debuginfod" != xno; then PKG_CHECK_MODULES([DEBUGINFOD], [libdebuginfod >= 0.179], ... fi ... the probing for pkg-config should not happen if --without-debuginfod is used. But in gdb/configure, I see that the probing for pkg-config actually appears outside the condition. Anyway, good if it works. > +diff --git a/gdb/NEWS b/gdb/NEWS > +index 9619842bc03..1457c99ff04 100644 > +--- a/gdb/NEWS > ++++ b/gdb/NEWS > +@@ -57,6 +57,8 @@ > + + * The Windows native target now supports target async. > + ++* gdb now supports zstd compressed debug sections (ELFCOMPRESS_ZSTD) for ELF. > ++ I'm not sure I understand the diff above, but I think it's missing an empty line between the previous bullet and the new bullet. Otherwise, that is OK for GDB. Simon