From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 6F9D2382CDDA for ; Thu, 1 Sep 2022 09:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F9D2382CDDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=foss.arm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=foss.arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DB1BD6E; Thu, 1 Sep 2022 02:43:34 -0700 (PDT) Received: from [10.57.16.162] (unknown [10.57.16.162]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 79F6E3F7B4; Thu, 1 Sep 2022 02:43:27 -0700 (PDT) Message-ID: Date: Thu, 1 Sep 2022 10:43:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Add OpenBSD ARM Little Endian BFD support. Content-Language: en-GB To: Frederic Cambus , binutils@sourceware.org References: <12d112cf-923c-81f7-0580-a1e5c33474f5@foss.arm.com> From: Richard Earnshaw In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3496.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 31/08/2022 23:12, Frederic Cambus wrote: > On Tue, Aug 30, 2022 at 02:55:00PM +0100, Richard Earnshaw wrote: > >> On 27/08/2022 18:28, Frederic Cambus wrote: > >>> + arm-*-openbsd*) >>> + targ_defvec=arm_elf32_le_vec >>> + targ_selvecs="arm_elf32_be_vec" >>> + ;; >> >> This is exactly the same content as the entry directly above it (netbsd), so >> please merge the two. It's a maintenance burden to have a lot of duplicated >> entries. > > Makes sense, and note taken. Revised diff inline below, and full patch > attached for convenience. Thanks, this is OK. R. > > diff --git a/bfd/config.bfd b/bfd/config.bfd > index 8c7be5da38a..a79a0e2bf5b 100644 > --- a/bfd/config.bfd > +++ b/bfd/config.bfd > @@ -90,7 +90,6 @@ case $targ in > arm*-*-aout | \ > arm-*-coff | \ > arm*-*-netbsdaout* | \ > - arm-*-openbsd* | \ > arm-*-oabi | \ > arm-*-riscix* | \ > arm*-*-symbianelf* | \ > @@ -383,7 +382,7 @@ case "${targ}" in > targ_defvec=arm_elf32_be_vec > targ_selvecs="arm_elf32_le_vec" > ;; > - arm-*-netbsd*) > + arm-*-netbsd* | arm-*-openbsd*) > targ_defvec=arm_elf32_le_vec > targ_selvecs="arm_elf32_be_vec" > ;; >